Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<!-- should not generate diagnostics -->
<script>
export let value = "ok";
</script>

<div>{value}</div>
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
---
source: crates/biome_js_analyze/tests/spec_tests.rs
expression: Issue9543Component.svelte
---
# Input
```svelte
<!-- should not generate diagnostics -->
<script>
export let value = "ok";
</script>

<div>{value}</div>

```
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export { default as Thing } from "./Issue9543Component.svelte";
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
source: crates/biome_js_analyze/tests/spec_tests.rs
expression: issue-9543-reexport.ts
---
# Input
```ts
export { default as Thing } from "./Issue9543Component.svelte";

```
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<!-- should not generate diagnostics -->
<script>
import { Thing as Something, Thing } from "./issue-9543-reexport";
</script>

<Something />
<Thing />
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
---
source: crates/biome_js_analyze/tests/spec_tests.rs
expression: valid-issue-9543.svelte
---
# Input
```svelte
<!-- should not generate diagnostics -->
<script>
import { Thing as Something, Thing } from "./issue-9543-reexport";
</script>

<Something />
<Thing />

```
Original file line number Diff line number Diff line change
Expand Up @@ -96,19 +96,19 @@ impl EmbeddedBuilder {
fn visit_js_import(&mut self, import: JsImport) -> Option<()> {
let clause = import.import_clause().ok()?;
if let Some(named_specifiers) = clause.named_specifiers() {
let imported_names = named_specifiers
.specifiers()
.iter()
.flatten()
.map(|specifier| specifier.imported_name());

for imported_name in imported_names {
let Some(imported_name) = imported_name else {
for specifier in named_specifiers.specifiers().iter().flatten() {
let Some(local_name) = specifier.local_name() else {
continue;
};
let Some(local_name) = local_name.as_js_identifier_binding() else {
continue;
};
let Ok(local_name) = local_name.name_token() else {
continue;
};
self.js_bindings.insert(
imported_name.text_trimmed_range(),
imported_name.token_text_trimmed(),
local_name.text_trimmed_range(),
local_name.token_text_trimmed(),
);
}
}
Expand Down Expand Up @@ -497,6 +497,20 @@ let variable = "salut";
assert!(contains_binding(&service, "variable"));
}

#[test]
fn tracks_renamed_named_imports_by_local_name() {
let source = r#"import { Thing as Something } from "somewhere";"#;

let mut service = EmbeddedExportedBindings::default();
let mut builder = service.builder();
visit_js_root(&mut builder, &parse_js(source));

service.finish(builder);

assert!(contains_binding(&service, "Something"));
assert!(!contains_binding(&service, "Thing"));
}

#[test]
fn tracks_import_and_binding_patterns() {
let source = r#"import { Component } from "somewhere";
Expand Down