fix(lint/useSimpleNumberKeys): ignore comments #957
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When checking if a key is a complex number we check the token value without trivia.
Minimal reproducible example: https://biomejs.dev/playground/?code=KAB7AAoAIAAgAC8ALwBuAAoAIAAgADEAOgAgADEACgB9ACkA
This also fixes another issue where we get a false positive on multiline binary, hex and octal numbers:
https://biomejs.dev/playground/?code=KAB7AAoAIAAgADAAYgAxADEAOgAgADEACgB9ACkAOwAKACgAewAKACAAIAAwAHgAMQA6ACAAMQAKAH0AKQA7AAoAKAB7AAoAIAAgADAAbwAxADoAIAAxAAoAfQApADsACgAKACgAewAwAGIAMQAxADoAIAAxAH0AKQA7AAoAKAB7ADAAeAAxADoAIAAxAH0AKQA7AAoAKAB7ADAAbwAxADoAIAAxAH0AKQA7AA%3D%3D
Closes: #918
Test Plan
Updated snapshot test