Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(css_parser): CSS Parser charset #268 #950

Merged
merged 2 commits into from
Nov 29, 2023
Merged

feat(css_parser): CSS Parser charset #268 #950

merged 2 commits into from
Nov 29, 2023

Conversation

denbezrukov
Copy link
Contributor

Summary

Add support for the chartset at rule.
https://developer.mozilla.org/en-US/docs/Web/CSS/@charset

Test Plan

cargo test

@github-actions github-actions bot added A-Parser Area: parser A-Tooling Area: internal tools L-CSS Language: CSS labels Nov 28, 2023
@github-actions GitHub Actions
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 49701 49701 0
Passed 48721 48721 0
Failed 980 980 0
Panics 0 0 0
Coverage 98.03% 98.03% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6322 6322 0
Passed 2036 2036 0
Failed 4286 4286 0
Panics 0 0 0
Coverage 32.20% 32.20% 0.00%

ts/babel

Test result main count This PR count Difference
Total 662 662 0
Passed 592 592 0
Failed 70 70 0
Panics 0 0 0
Coverage 89.43% 89.43% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17646 17646 0
Passed 13453 13453 0
Failed 4191 4191 0
Panics 2 2 0
Coverage 76.24% 76.24% 0.00%

ematipico
ematipico approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic looks good! I left a comment, let me know what you think

xtask/codegen/css.ungram Outdated Show resolved Hide resolved
crates/biome_css_parser/src/syntax/parse_error.rs
@@ -130,6 +134,33 @@ pub(crate) fn expected_any_pseudo_class(p: &CssParser, range: TextRange) -> Pars
.into_diagnostic(p)
}

pub(crate) fn expected_any_at_rule(p: &CssParser, range: TextRange) -> ParseDiagnostic {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

@denbezrukov denbezrukov merged commit 5999c74 into main Nov 29, 2023
16 checks passed
@denbezrukov denbezrukov deleted the feat/chartset_at_rule branch November 29, 2023 16:39
yossydev pushed a commit to yossydev/biome that referenced this pull request Dec 3, 2023
@denbezrukov
feat(css_parser): CSS Parser charset biomejs#268 (biomejs#950)
7aec1bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
A-Parser Area: parser A-Tooling Area: internal tools L-CSS Language: CSS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denbezrukov @ematipico