Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(website): show sponsors on japanese document #945

Merged
merged 5 commits into from
Nov 28, 2023

Conversation

unvalley
Copy link
Member

@unvalley unvalley commented Nov 28, 2023

Summary

This PR shows sponsors on Japanese document

Test Plan

Screenshot 2023-11-29 at 1 55 23

@unvalley unvalley requested a review from a team as a code owner November 28, 2023 16:42
@github-actions github-actions bot added the A-Website Area: website label Nov 28, 2023
@unvalley unvalley changed the title docs(website): show sponsors on japanese and add kaname docs(website): show sponsors on japanese document and add kaname Nov 28, 2023
@unvalley unvalley changed the title docs(website): show sponsors on japanese document and add kaname docs(website): show sponsors on japanese document Nov 28, 2023
@unvalley
Copy link
Member Author

unvalley commented Nov 28, 2023

Addressing this for all translation pages are tough, we need some ways to handle this.

Or, we only show sponsors on english doc.

@unvalley unvalley merged commit cc0d371 into biomejs:main Nov 28, 2023
4 checks passed
@unvalley unvalley deleted the show-sponsors-on-japanese branch November 28, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Website Area: website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants