perf: add .skip(1) to .ancestors() calls in a bunch of places

crates/biome_css_analyze/src/lint/a11y/use_generic_font_names.rs

@@ -158,6 +158,7 @@ impl Rule for UseGenericFontNames {
 fn is_in_font_face_at_rule(node: &CssGenericProperty) -> bool {
     node.syntax()
         .ancestors()
+        .skip(1)
         .find(|n| n.kind() == CssSyntaxKind::CSS_AT_RULE)
         .and_then(|n| n.cast::<CssAtRule>())
         .and_then(|n| n.rule().ok())

crates/biome_css_analyze/src/lint/correctness/no_unknown_unit.rs

@@ -111,15 +111,15 @@ impl Rule for NoUnknownUnit {
                         if unit == "x" {
                             let mut allow_x = false;
 
-                            for ancestor in dimension.unit_token().ok()?.ancestors() {
+                            for ancestor in dimension.unit_token().ok()?.ancestors().skip(1) {
                                 match ancestor.kind() {
                                     CssSyntaxKind::CSS_FUNCTION => {
                                         let function_name_token = ancestor
-                                    .cast::<CssFunction>()?
-                                    .name()
-                                    .ok()?
-                                    .as_css_identifier()
-                                    .and_then(|name| name.value_token().ok())?;
+                                            .cast::<CssFunction>()?
+                                            .name()
+                                            .ok()?
+                                            .as_css_identifier()
+                                            .and_then(|name| name.value_token().ok())?;
                                         let function_name = function_name_token
                                             .text_trimmed()
                                             .to_ascii_lowercase_cow();

crates/biome_css_analyze/src/lint/correctness/no_unmatchable_anb_selector.rs

@@ -129,6 +129,7 @@ fn is_within_not_pseudo_class(node: &AnyCssPseudoClassNth) -> bool {
     let number_of_not = node
         .syntax()
         .ancestors()
+        .skip(1)
         .filter_map(|n| n.cast::<CssPseudoClassFunctionSelectorList>())
         .filter_map(|n| n.name().ok())
         .filter_map(|n| n.value_token().ok())

crates/biome_css_analyze/src/lint/suspicious/no_duplicate_properties.rs

@@ -74,6 +74,7 @@ impl Rule for NoDuplicateProperties {
             if prop
                 .syntax()
                 .ancestors()
+                .skip(1)
                 .any(|node| CssKeyframesAtRule::can_cast(node.kind()))
             {
                 continue;

crates/biome_html_analyze/src/lint/a11y/no_autofocus.rs

@@ -127,7 +127,7 @@ fn is_inside_allowed_context(attr: &HtmlAttribute) -> Option<bool> {
     let mut skip_first_element = true;
 
     // Walk up the ancestors to find if we're inside a dialog or popover
-    for ancestor in attr.syntax().ancestors() {
+    for ancestor in attr.syntax().ancestors().skip(1) {
         let Some(tag_element) = get_tag_element(&ancestor) else {
             continue;
         };

crates/biome_html_analyze/src/lint/nursery/use_vue_valid_v_if.rs

@@ -169,6 +169,7 @@ impl Rule for UseVueValidVIf {
 fn find_conflicting_else_directives(v_if: &VueDirective) -> Option<TextRange> {
     v_if.syntax()
         .ancestors()
+        .skip(1)
         .find_map(HtmlAttributeList::cast)?
         .into_iter()
         .find_map(|attr| {

crates/biome_js_analyze/src/assist/source/use_sorted_attributes.rs

@@ -139,7 +139,7 @@ impl Rule for UseSortedAttributes {
     }
 
     fn text_range(ctx: &RuleContext<Self>, _state: &Self::State) -> Option<TextRange> {
-        ctx.query().syntax().ancestors().find_map(|node| {
+        ctx.query().syntax().ancestors().skip(1).find_map(|node| {
             JsxOpeningElement::cast_ref(&node)
                 .map(|element| element.range())
                 .or_else(|| JsxSelfClosingElement::cast_ref(&node).map(|element| element.range()))

crates/biome_js_analyze/src/assist/source/use_sorted_keys.rs

@@ -288,6 +288,7 @@ impl Rule for UseSortedKeys {
         ctx.query()
             .syntax()
             .ancestors()
+            .skip(1)
             .find_map(JsObjectExpression::cast)
             .map(|object| object.range())
     }

crates/biome_js_analyze/src/frameworks/mod.rs

@@ -55,6 +55,7 @@ pub(crate) fn is_framework_lib_export(binding: &Binding, package_names: &[&str])
     binding
         .syntax()
         .ancestors()
+        .skip(1)
         .find_map(|ancestor| JsImport::cast(ancestor)?.source_text().ok())
         .is_some_and(|source| package_names.contains(&source.text()))
 }

crates/biome_js_analyze/src/frameworks/vue/vue_component.rs

@@ -754,6 +754,7 @@ impl AnyVueSetupDeclaration {
             && let Some(declarator) = binding
                 .syntax()
                 .ancestors()
+                .skip(1)
                 .find_map(|syntax| JsVariableDeclarator::try_cast(syntax).ok())
             && let Some(initializer) = declarator.initializer()
             && let Some(expression) = initializer
@@ -781,6 +782,7 @@ impl AnyVueSetupDeclaration {
             && let Some(declarator) = binding
                 .syntax()
                 .ancestors()
+                .skip(1)
                 .find_map(|syntax| JsVariableDeclarator::try_cast(syntax).ok())
             && let Some(initializer) = declarator.initializer()
             && let Some(expression) = initializer
@@ -811,6 +813,7 @@ impl AnyVueSetupDeclaration {
                     && let Some(declarator) = binding
                         .syntax()
                         .ancestors()
+                        .skip(1)
                         .find_map(|syntax| JsVariableDeclarator::try_cast(syntax).ok())
                     && let Some(decl_initializer) = declarator.initializer()
                     && let Some(decl_expr) = decl_initializer

crates/biome_js_analyze/src/lint/a11y/use_aria_activedescendant_with_tabindex.rs

@@ -106,6 +106,7 @@ impl Rule for UseAriaActivedescendantWithTabindex {
         let old_attribute_list = descendant_attribute
             .syntax()
             .ancestors()
+            .skip(1)
             .find_map(JsxAttributeList::cast)?;
 
         let new_attribute = jsx_attribute(AnyJsxAttributeName::JsxName(jsx_name(

crates/biome_js_analyze/src/lint/complexity/no_this_in_static.rs

@@ -100,6 +100,7 @@ impl Rule for NoThisInStatic {
         let static_method = this_super_expression
             .syntax()
             .ancestors()
+            .skip(1)
             .find(|x| {
                 AnyJsControlFlowRoot::can_cast(x.kind())
                     && !JsArrowFunctionExpression::can_cast(x.kind())

crates/biome_js_analyze/src/lint/complexity/no_useless_constructor.rs

@@ -164,7 +164,11 @@ impl Rule for NoUselessConstructor {
                 return None;
             }
         }
-        let class = constructor.syntax().ancestors().find_map(AnyJsClass::cast);
+        let class = constructor
+            .syntax()
+            .ancestors()
+            .skip(1)
+            .find_map(AnyJsClass::cast);
         if let Some(class) = &class
             && !class.decorators().is_empty()
         {

crates/biome_js_analyze/src/lint/complexity/no_useless_label.rs

@@ -58,7 +58,7 @@ impl Rule for NoUselessLabel {
             _ => None,
         }?;
         let label = label_token.text_trimmed();
-        for parent in stmt.syntax().ancestors() {
+        for parent in stmt.syntax().ancestors().skip(1) {
             if is_breakable_statement_kind(parent.kind()) {
                 if let Some(labeled_stmt) = JsLabeledStatement::cast(parent.parent()?)
                     && labeled_stmt.label_token().ok()?.text_trimmed() == label

crates/biome_js_analyze/src/lint/complexity/no_useless_this_alias.rs

@@ -89,6 +89,7 @@ impl Rule for NoUselessThisAlias {
         let this_scope = declarator
             .syntax()
             .ancestors()
+            .skip(1)
             .find_map(AnyJsControlFlowRoot::cast)?;
         for write in id.all_writes(model) {
             let assign = JsAssignmentExpression::cast(write.syntax().parent()?)?;
@@ -106,6 +107,7 @@ impl Rule for NoUselessThisAlias {
             let current_this_scope = reference
                 .syntax()
                 .ancestors()
+                .skip(1)
                 .filter(|x| !JsArrowFunctionExpression::can_cast(x.kind()))
                 .find_map(AnyJsControlFlowRoot::cast)?;
             if this_scope != current_this_scope {
@@ -138,6 +140,7 @@ impl Rule for NoUselessThisAlias {
         let var_decl = declarator
             .syntax()
             .ancestors()
+            .skip(1)
             .find_map(JsVariableDeclaration::cast)?;
         let mut mutation = ctx.root().begin();
         let this_expr = AnyJsExpression::from(make::js_this_expression(make::token(T![this])));

crates/biome_js_analyze/src/lint/correctness/no_constant_condition.rs

@@ -160,7 +160,7 @@ impl ConditionalStatement {
     }
     // Checks if the self statement is in a generator function
     fn is_in_generator_function(&self) -> bool {
-        self.syntax().ancestors().any(|node| {
+        self.syntax().ancestors().skip(1).any(|node| {
             match JsFunctionDeclaration::try_cast(node) {
                 Ok(func_decl) => func_decl.star_token(),
                 Err(node) => {

crates/biome_js_analyze/src/lint/correctness/no_constructor_return.rs

@@ -76,6 +76,7 @@ impl Rule for NoConstructorReturn {
         let _arg = ret.argument()?;
         ret.syntax()
             .ancestors()
+            .skip(1)
             .find(|x| AnyJsControlFlowRoot::can_cast(x.kind()))
             .and_then(JsConstructorClassMember::cast)
     }

crates/biome_js_analyze/src/lint/correctness/no_invalid_constructor_super.rs

@@ -122,6 +122,7 @@ impl Rule for NoInvalidConstructorSuper {
         let extends_clause = node
             .syntax()
             .ancestors()
+            .skip(1)
             .find_map(|node| AnyJsClass::cast(node)?.extends_clause());
 
         match (super_range, extends_clause) {

crates/biome_js_analyze/src/lint/correctness/no_nested_component_definitions.rs

@@ -112,6 +112,7 @@ impl Rule for NoNestedComponentDefinitions {
             && let Some(parent_component) = node
                 .syntax()
                 .ancestors()
+                .skip(1)
                 .skip_while(|ancestor| ancestor.eq(node.syntax()))
                 .find_map(|syntax| ReactComponentInfo::from_declaration(&syntax))
         {

crates/biome_js_analyze/src/lint/correctness/no_process_global.rs

@@ -96,6 +96,7 @@ impl Rule for NoProcessGlobal {
             .query()
             .syntax()
             .ancestors()
+            .skip(1)
             .find(is_top_level_statement)?;
         // insert new import at:
         // 1. after the most recent import statement. Or, if no such import exist

crates/biome_js_analyze/src/lint/correctness/no_setter_return.rs

@@ -92,6 +92,7 @@ impl Rule for NoSetterReturn {
         let _arg = ret.argument()?;
         ret.syntax()
             .ancestors()
+            .skip(1)
             .find(|x| AnyJsControlFlowRoot::can_cast(x.kind()))
             .and_then(JsSetterMember::cast)
     }

crates/biome_js_analyze/src/lint/correctness/no_solid_destructured_props.rs

@@ -89,6 +89,7 @@ impl Rule for NoSolidDestructuredProps {
         let Some(parameters) = binding_pattern
             .syntax()
             .ancestors()
+            .skip(1)
             .find_map(JsParameters::cast)
         else {
             return vec![];
@@ -186,6 +187,7 @@ fn is_binding_a_jsx_prop(binding: &AnyJsBinding, model: &SemanticModel) -> Optio
             if reference
                 .syntax()
                 .ancestors()
+                .skip(1)
                 .find_map(JsxExpressionAttributeValue::cast)
                 .is_some()
             {

crates/biome_js_analyze/src/lint/correctness/no_undeclared_variables.rs

@@ -102,7 +102,7 @@ impl Rule for NoUndeclaredVariables {
                 // arguments object within non-arrow functions
                 if text == "arguments" {
                     let is_in_non_arrow_function =
-                        identifier.syntax().ancestors().any(|ancestor| {
+                        identifier.syntax().ancestors().skip(1).any(|ancestor| {
                             !matches!(
                                 AnyJsFunction::cast(ancestor),
                                 None | Some(AnyJsFunction::JsArrowFunctionExpression(_))

crates/biome_js_analyze/src/lint/correctness/use_qwik_valid_lexical_scope.rs

@@ -95,6 +95,7 @@ impl Rule for UseQwikValidLexicalScope {
 fn is_wrapped_with_dollar(expr: &AnyJsExpression) -> bool {
     expr.syntax()
         .ancestors()
+        .skip(1)
         .find_map(JsCallExpression::cast)
         .and_then(|call| call.callee().ok())
         .and_then(|callee| callee.as_js_reference_identifier())

crates/biome_js_analyze/src/lint/nursery/no_shadow.rs

@@ -249,19 +249,22 @@ fn is_inside_type_parameter(binding: &Binding) -> bool {
     binding
         .syntax()
         .ancestors()
+        .skip(1)
         .any(|ancestor| ancestor.cast::<TsTypeParameter>().is_some())
 }
 
 fn is_inside_type_member(binding: &Binding) -> bool {
     binding
         .syntax()
         .ancestors()
+        .skip(1)
         .any(|ancestor| ancestor.cast::<TsPropertySignatureTypeMember>().is_some())
 }
 
 fn is_inside_function_parameters(binding: &Binding) -> bool {
     binding
         .syntax()
         .ancestors()
+        .skip(1)
         .any(|ancestor| ancestor.cast::<JsParameterList>().is_some())
 }

crates/biome_js_analyze/src/lint/nursery/no_unnecessary_conditions.rs

@@ -313,6 +313,7 @@ fn check_condition_necessity(
     let inside_catch = expr
         .syntax()
         .ancestors()
+        .skip(1)
         .any(|ancestor| JsCatchClause::can_cast(ancestor.kind()));
 
     if inside_catch {