Skip to content

refactor(markdown-parser): replace remaining magic numbers with named constants #9264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ematipico merged 1 commit into from
Feb 27, 2026
Merged

refactor(markdown-parser): replace remaining magic numbers with named constants #9264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/biome_markdown_parser/src/parser.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,7 @@ fn count_leading_indent(text: &str) -> usize {
for c in text.chars() {
match c {
' ' => count += 1,
'\t' => count += 4,
'\t' => count += TAB_STOP_SPACES,
_ => break,
}
}
Expand Down
2 changes: 1 addition & 1 deletion crates/biome_markdown_parser/src/syntax/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,7 @@ fn consume_indent_prefix(p: &mut MarkdownParser, indent: usize) {
if text == " " {
consumed += 1;
} else if text == "\t" {
consumed += 4;
consumed += TAB_STOP_SPACES;
} else {
break;
}
Expand Down
4 changes: 3 additions & 1 deletion crates/biome_markdown_parser/src/to_html.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1148,7 +1148,9 @@ fn render_fenced_code_block(
indent
});
let container_indent = list_indent + quote_indent;
let fence_indent = fence_leading_indent.saturating_sub(container_indent).min(3);
let fence_indent = fence_leading_indent
.saturating_sub(container_indent)
.min(MAX_BLOCK_PREFIX_INDENT);
let content_indent = container_indent + fence_indent;

// Get info string (language) - process escapes
Expand Down