Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): fix title tags #925

Merged
merged 2 commits into from
Nov 28, 2023
Merged

fix(website): fix title tags #925

merged 2 commits into from
Nov 28, 2023

Conversation

yanthomasdev
Copy link
Contributor

Summary

Starlight's title option was misconfigured by including an empty string (""). I believe this was done to use a logo-only title, but Starlight offers a proper option for this with logo.replacesTitle: true. In resume, this PR adds the correct configuration, fixing:

  • Title tags being generated as, for example, Getting Started | rather than Getting Started | Biome.
  • The home page link in the logo missing a sr-only text, meaning no a11y.

Note that now the home page biomejs.dev would have a title of Biome | Biome, but I've changed the head.title frontmatter property to only Biome. Feel free to use another name for the home page if you prefer.

Test Plan

By visually inspecting the website, you can see the browser's tab title following <page title> | Biome.

Also, by Inspecting the logo with Dev Tools you will now be able to see the following:

<span class="sr-only astro-onp6g3ne"> Biome </span>

rather than:

<span class="astro-hdkvlegf">  </span>

@github-actions github-actions bot added the A-Website Area: website label Nov 27, 2023
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Yan! Your expertise is very welcome 🙏

@ematipico ematipico merged commit ebeadd0 into biomejs:main Nov 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Website Area: website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants