Skip to content

fix(css): ignore font properties inside @supports rules in useGenericFontNames #8914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ddmoney420 wants to merge 2 commits into from
Closed

fix(css): ignore font properties inside @supports rules in useGenericFontNames #8914

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
444d374
fix(css): ignore font properties inside @supports rules in useGeneric…
ddmoney420 Jan 29, 2026
f665652
fix: check all ancestors for @supports, not just the first at-rule
ddmoney420 Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-use-generic-font-names-supports.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@biomejs/biome": patch
---

Fixed [#8845](https://github.com/biomejs/biome/issues/8845): [`useGenericFontNames`](https://biomejs.dev/linter/rules/use-generic-font-names/) no longer reports a false positive when `font` or `font-family` is used inside `@supports` rules for feature detection.
20 changes: 20 additions & 0 deletions crates/biome_css_analyze/src/lint/a11y/use_generic_font_names.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ declare_lint_rule! {
/// - Property with a keyword value such as `inherit`, `initial`.
/// - The last value being a CSS variable.
/// - `font-family` property in an `@font-face` rule.
/// - `font` or `font-family` property in an `@supports` rule (feature detection).
///
/// ## Examples
///
Expand Down Expand Up @@ -62,6 +63,10 @@ declare_lint_rule! {
/// @font-face { font-family: Gentium; }
/// ```
///
/// ```css
/// @supports (font: -apple-system-body) {}
/// ```
///
pub UseGenericFontNames {
version: "1.8.0",
name: "useGenericFontNames",
Expand All @@ -88,6 +93,12 @@ impl Rule for UseGenericFontNames {
return None;
}

// Ignore `@supports`. The font property inside @supports is used for feature detection,
// not as an actual font-family declaration.
if is_in_supports_at_rule(node) {
return None;
}

let is_font_family = property_name == "font-family";
let is_font = property_name == "font";

Expand Down Expand Up @@ -158,6 +169,15 @@ fn is_in_font_face_at_rule(node: &CssGenericProperty) -> bool {
.is_some_and(|n| matches!(n, AnyCssAtRule::CssFontFaceAtRule(_)))
}

fn is_in_supports_at_rule(node: &CssGenericProperty) -> bool {
node.syntax()
.ancestors()
.find(|n| n.kind() == CssSyntaxKind::CSS_AT_RULE)
.and_then(|n| n.cast::<CssAtRule>())
.and_then(|n| n.rule().ok())
.is_some_and(|n| matches!(n, AnyCssAtRule::CssSupportsAtRule(_)))
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
}

fn is_shorthand_font_property_with_keyword(properties: &CssGenericComponentValueList) -> bool {
properties.into_iter().len() == 1
&& properties
Expand Down
4 changes: 3 additions & 1 deletion crates/biome_css_analyze/tests/specs/a11y/useGenericFontNames/valid.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,6 @@ a { font-family: Arial, var(--fallback); }
a { font: 1em "Noto Serif", var(--serif); }
a { font: 14px/1.5 Arial, var(--fallback); }
a { font-family: revert }
a { font-family: revert-layer }
a { font-family: revert-layer }
@supports (font: -apple-system-body) {}
@supports (font-family: -apple-system) {}
2 changes: 2 additions & 0 deletions crates/biome_css_analyze/tests/specs/a11y/useGenericFontNames/valid.css.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,6 @@ a { font: 1em "Noto Serif", var(--serif); }
a { font: 14px/1.5 Arial, var(--fallback); }
a { font-family: revert }
a { font-family: revert-layer }
@supports (font: -apple-system-body) {}
@supports (font-family: -apple-system) {}
```
Loading