Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade Rust to 1.74.0 #889

Merged
merged 3 commits into from
Nov 26, 2023
Merged

Conversation

togami2864
Copy link
Contributor

Summary

SSIA #878

Test Plan

The current CI should pass

@github-actions github-actions bot added A-Formatter Area: formatter A-Tooling Area: internal tools labels Nov 26, 2023
@togami2864
Copy link
Contributor Author

!bench_formatter
!bench_parser
!bench_analyzer

Copy link
Contributor

Analyzer Benchmark Results

group                     main                                   pr
-----                     ----                                   --
analyzer/css.js           1.00      3.7±0.02ms     3.3 MB/sec    1.00      3.7±0.03ms     3.2 MB/sec
analyzer/index.js         1.00      7.5±0.06ms     4.2 MB/sec    1.00      7.4±0.09ms     4.2 MB/sec
analyzer/lint.ts          1.01      5.6±0.19ms     7.5 MB/sec    1.00      5.5±0.07ms     7.6 MB/sec
analyzer/parser.ts        1.01     11.6±0.08ms     4.2 MB/sec    1.00     11.5±0.05ms     4.3 MB/sec
analyzer/router.ts        1.00      3.6±0.04ms     6.5 MB/sec    1.00      3.6±0.11ms     6.5 MB/sec
analyzer/statement.ts     1.01     10.4±0.52ms     3.4 MB/sec    1.00     10.3±0.08ms     3.4 MB/sec
analyzer/typescript.ts    1.00     16.8±0.12ms     3.2 MB/sec    1.00     16.7±0.13ms     3.3 MB/sec

Copy link
Contributor

Formatter Benchmark Results

group                                    main                                   pr
-----                                    ----                                   --
formatter/big5-added.json                1.04    376.9±1.66µs    44.8 MB/sec    1.00    363.7±8.41µs    46.5 MB/sec
formatter/canada.json                    1.11    182.6±5.18ms    11.8 MB/sec    1.00    165.0±5.13ms    13.0 MB/sec
formatter/checker.ts                     1.04    285.3±2.73ms     9.1 MB/sec    1.00    275.2±6.86ms     9.4 MB/sec
formatter/compiler.js                    1.04    163.8±2.31ms     6.4 MB/sec    1.00    157.9±2.92ms     6.6 MB/sec
formatter/d3.min.js                      1.07    126.5±2.35ms     2.1 MB/sec    1.00    118.5±2.75ms     2.2 MB/sec
formatter/db.json                        1.02     10.8±0.09ms    17.0 MB/sec    1.00     10.6±0.43ms    17.2 MB/sec
formatter/dojo.js                        1.06      9.0±0.03ms     7.6 MB/sec    1.00      8.5±0.12ms     8.1 MB/sec
formatter/eucjp.json                     1.01   641.9±11.47µs    61.0 MB/sec    1.00    636.6±4.06µs    61.5 MB/sec
formatter/ios.d.ts                       1.10    192.2±2.37ms     9.7 MB/sec    1.00    174.5±2.83ms    10.7 MB/sec
formatter/jquery.min.js                  1.07     36.9±0.33ms     2.2 MB/sec    1.00     34.3±0.20ms     2.4 MB/sec
formatter/math.js                        1.05    255.9±2.61ms     2.5 MB/sec    1.00    244.3±4.04ms     2.7 MB/sec
formatter/package-lock.json              1.02      4.6±0.02ms    29.9 MB/sec    1.00      4.5±0.02ms    30.4 MB/sec
formatter/parser.ts                      1.09      6.3±0.08ms     7.7 MB/sec    1.00      5.8±0.04ms     8.4 MB/sec
formatter/pixi.min.js                    1.07    137.2±1.66ms     3.2 MB/sec    1.00    128.8±2.11ms     3.4 MB/sec
formatter/react-dom.production.min.js    1.07     41.8±0.40ms     2.8 MB/sec    1.00     39.1±0.63ms     2.9 MB/sec
formatter/react.production.min.js        1.09      2.2±0.03ms     2.9 MB/sec    1.00  1978.1±28.72µs     3.1 MB/sec
formatter/router.ts                      1.07      2.2±0.04ms    10.7 MB/sec    1.00      2.1±0.02ms    11.4 MB/sec
formatter/tex-chtml-full.js              1.09    335.6±6.77ms     2.7 MB/sec    1.00    308.0±6.05ms     3.0 MB/sec
formatter/three.min.js                   1.10    166.9±4.08ms     3.5 MB/sec    1.00    151.3±3.16ms     3.9 MB/sec
formatter/typescript.js                  1.06  1123.3±13.35ms     8.5 MB/sec    1.00  1055.0±12.56ms     9.0 MB/sec
formatter/vue.global.prod.js             1.07     56.4±0.75ms     2.1 MB/sec    1.00     53.0±3.79ms     2.3 MB/sec

Copy link
Contributor

Parser Benchmark Results

group                                          main                                   pr
-----                                          ----                                   --
parser/big5-added.json/cached                  1.01     99.5±1.87µs   169.7 MB/sec    1.00     98.8±0.98µs   171.0 MB/sec
parser/big5-added.json/uncached                1.02    125.5±0.47µs   134.6 MB/sec    1.00    123.0±0.34µs   137.4 MB/sec
parser/canada.json/cached                      1.03     52.0±1.79ms    41.3 MB/sec    1.00     50.4±2.33ms    42.6 MB/sec
parser/canada.json/uncached                    1.01     54.2±2.01ms    39.6 MB/sec    1.00     53.7±1.01ms    40.0 MB/sec
parser/checker.ts/cached                       1.00     78.3±2.13ms    33.2 MB/sec    1.00     78.1±3.50ms    33.3 MB/sec
parser/checker.ts/uncached                     1.00     81.5±1.18ms    31.9 MB/sec    1.03     84.1±1.67ms    30.9 MB/sec
parser/compiler.js/cached                      1.00     43.7±0.87ms    24.0 MB/sec    1.01     44.0±1.01ms    23.8 MB/sec
parser/compiler.js/uncached                    1.00     46.9±0.48ms    22.3 MB/sec    1.00     46.7±0.70ms    22.4 MB/sec
parser/d3.min.js/cached                        1.01     29.4±0.31ms     8.9 MB/sec    1.00     29.0±0.34ms     9.0 MB/sec
parser/d3.min.js/uncached                      1.01     30.8±0.29ms     8.5 MB/sec    1.00     30.4±0.36ms     8.6 MB/sec
parser/db.json/cached                          1.00      3.2±0.07ms    57.1 MB/sec    1.00      3.2±0.03ms    57.4 MB/sec
parser/db.json/uncached                        1.00      3.6±0.07ms    50.8 MB/sec    1.00      3.6±0.03ms    50.8 MB/sec
parser/dojo.js/cached                          1.01      2.3±0.03ms    29.3 MB/sec    1.00      2.3±0.06ms    29.4 MB/sec
parser/dojo.js/uncached                        1.00      2.6±0.03ms    26.0 MB/sec    1.00      2.6±0.03ms    26.0 MB/sec
parser/eucjp.json/cached                       1.00    187.5±1.68µs   208.9 MB/sec    1.01    189.0±2.79µs   207.2 MB/sec
parser/eucjp.json/uncached                     1.00    219.3±2.30µs   178.6 MB/sec    1.01    222.3±1.99µs   176.1 MB/sec
parser/ios.d.ts/cached                         1.04     70.5±2.00ms    26.5 MB/sec    1.00     67.9±2.45ms    27.5 MB/sec
parser/ios.d.ts/uncached                       1.03     71.0±1.53ms    26.3 MB/sec    1.00     69.2±1.27ms    27.0 MB/sec
parser/jquery.min.js/cached                    1.01      7.8±0.06ms    10.6 MB/sec    1.00      7.7±0.07ms    10.7 MB/sec
parser/jquery.min.js/uncached                  1.01      8.3±0.04ms    10.0 MB/sec    1.00      8.2±0.04ms    10.1 MB/sec
parser/math.js/cached                          1.00     55.6±1.67ms    11.6 MB/sec    1.05     58.3±3.12ms    11.1 MB/sec
parser/math.js/uncached                        1.00     57.0±0.46ms    11.4 MB/sec    1.05     60.0±1.69ms    10.8 MB/sec
parser/package-lock.json/cached                1.01  1425.1±32.24µs    96.7 MB/sec    1.00  1416.3±12.36µs    97.3 MB/sec
parser/package-lock.json/uncached              1.00  1526.3±18.44µs    90.3 MB/sec    1.01  1534.6±15.93µs    89.8 MB/sec
parser/parser.ts/cached                        1.00  1739.1±58.08µs    28.1 MB/sec    1.00  1732.2±86.98µs    28.2 MB/sec
parser/parser.ts/uncached                      1.00  1919.5±14.16µs    25.4 MB/sec    1.00  1925.5±28.21µs    25.3 MB/sec
parser/pixi.min.js/cached                      1.01     34.5±0.79ms    12.7 MB/sec    1.00     34.2±0.72ms    12.8 MB/sec
parser/pixi.min.js/uncached                    1.01     36.9±0.43ms    11.9 MB/sec    1.00     36.4±0.57ms    12.1 MB/sec
parser/react-dom.production.min.js/cached      1.01     10.3±0.07ms    11.2 MB/sec    1.00     10.2±0.30ms    11.3 MB/sec
parser/react-dom.production.min.js/uncached    1.00     11.1±0.05ms    10.3 MB/sec    1.00     11.2±0.35ms    10.3 MB/sec
parser/react.production.min.js/cached          1.01    482.7±5.47µs    12.7 MB/sec    1.00    478.4±5.38µs    12.9 MB/sec
parser/react.production.min.js/uncached        1.00    542.7±8.25µs    11.3 MB/sec    1.00    541.6±6.77µs    11.4 MB/sec
parser/router.ts/cached                        1.01   567.2±34.32µs    41.5 MB/sec    1.00    560.1±9.20µs    42.0 MB/sec
parser/router.ts/uncached                      1.00    657.4±8.08µs    35.8 MB/sec    1.00    658.2±7.78µs    35.7 MB/sec
parser/tex-chtml-full.js/cached                1.00     77.3±2.14ms    11.8 MB/sec    1.02     78.9±1.87ms    11.6 MB/sec
parser/tex-chtml-full.js/uncached              1.00     78.2±1.11ms    11.7 MB/sec    1.04     81.4±1.02ms    11.2 MB/sec
parser/three.min.js/cached                     1.00     38.4±0.67ms    15.3 MB/sec    1.01     38.8±0.89ms    15.1 MB/sec
parser/three.min.js/uncached                   1.00     40.3±0.60ms    14.6 MB/sec    1.01     40.8±1.13ms    14.4 MB/sec
parser/typescript.js/cached                    1.00    318.8±4.95ms    29.8 MB/sec    1.00    317.7±4.38ms    29.9 MB/sec
parser/typescript.js/uncached                  1.01    325.0±4.10ms    29.2 MB/sec    1.00    323.4±3.39ms    29.4 MB/sec
parser/vue.global.prod.js/cached               1.01     12.7±0.08ms     9.5 MB/sec    1.00     12.7±0.07ms     9.5 MB/sec
parser/vue.global.prod.js/uncached             1.00     13.5±0.04ms     8.9 MB/sec    1.00     13.5±0.09ms     8.9 MB/sec

@unvalley unvalley merged commit b9f8ffe into biomejs:main Nov 26, 2023
13 checks passed
ematipico pushed a commit that referenced this pull request Nov 26, 2023
@Conaclos Conaclos added the A-Changelog Area: changelog label Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Formatter Area: formatter A-Tooling Area: internal tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants