fix(matcher): fix wrongly ignored paths #859
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #856
When specific file or directory names are specified, it's necessary to check if they are included in the source path by traversing back through the path's ancestors. In my implementation, I use
ends_with
. Thisends_with
accurately recognizes paths, and in cases like the following, it will returnfalse
as expected:https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=33143b2b647a15d2424b2187a6411fbc
The documentation of
Path::ends_with
: https://doc.rust-lang.org/std/path/struct.Path.html#method.ends_withTest Plan
I've added a test case for single file or directory name listed in
.gitignore
. All tests should pass.