Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid escape for jsx #842

Merged
merged 1 commit into from
Nov 23, 2023
Merged

fix: avoid escape for jsx #842

merged 1 commit into from
Nov 23, 2023

Conversation

Gumichocopengin8
Copy link
Contributor

@Gumichocopengin8 Gumichocopengin8 commented Nov 23, 2023 •
edited
Loading

Summary

fix #826

Test Plan

cargo test -p biome_js_formatter
Check this Prettier playground, and see prettier and newly added test case snap are identical

@Gumichocopengin8 Gumichocopengin8 marked this pull request as ready for review November 23, 2023 00:40
@github-actions github-actions bot added A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages L-JSON Language: JSON and super languages labels Nov 23, 2023
@ematipico ematipico merged commit 55e8531 into biomejs:main Nov 23, 2023
12 checks passed
@Gumichocopengin8 Gumichocopengin8 deleted the fix/avoid-escape branch November 23, 2023 12:36
@ematipico ematipico mentioned this pull request Nov 25, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages L-JSON Language: JSON and super languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

📝 Formatting issue: Incorrectly removes escape characters for html/jsx pattern regexes
2 participants
@Gumichocopengin8 @ematipico