Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(css_parser): CSS Parser pseudo element selector #268 #839

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

denbezrukov
Copy link
Contributor

@denbezrukov denbezrukov commented Nov 22, 2023

Summary

Error recovery for function identifier and identifier:
See snapshots for details.

: {}
: .class{}
.class: {}


:dir( {}
:dir() {}
:dir(ltr {}
:dir(invalid {}
:dir(.invalid) {}
:dir(.invalid {}
:dir(ltr .class {}
:dir(ltr .class) {}
:dir(invalid .class {}
:dir(invalid .class) {}
:dir(.invalid

  i Expected a ltr, or a rtl here.
  
   > 9 │ :dir(invalid .class {}
       │      ^^^^^^^^^^^^^^
  
  × expected `)` but instead found `{`
 
   > 9 │ :dir(invalid .class {}
       │                     ^

Test Plan

cargo test

- error recovery for function identifier and identifier
@github-actions github-actions bot added A-Parser Area: parser A-Tooling Area: internal tools L-CSS Language: CSS labels Nov 22, 2023
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 49701 49701 0
Passed 48721 48721 0
Failed 980 980 0
Panics 0 0 0
Coverage 98.03% 98.03% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6322 6322 0
Passed 2036 2036 0
Failed 4286 4286 0
Panics 0 0 0
Coverage 32.20% 32.20% 0.00%

ts/babel

Test result main count This PR count Difference
Total 662 662 0
Passed 592 592 0
Failed 70 70 0
Panics 0 0 0
Coverage 89.43% 89.43% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17646 17646 0
Passed 13454 13454 0
Failed 4190 4190 0
Panics 2 2 0
Coverage 76.24% 76.24% 0.00%

@denbezrukov denbezrukov merged commit 98aeb72 into main Nov 24, 2023
16 checks passed
@denbezrukov denbezrukov deleted the pseudo-class-error-recovery branch November 24, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Parser Area: parser A-Tooling Area: internal tools L-CSS Language: CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant