Skip to content

chore(parser): increase size of SyntaxKindSet bitfield #7994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ematipico merged 1 commit into from
Nov 5, 2025
Merged

chore(parser): increase size of SyntaxKindSet bitfield #7994

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions crates/biome_rowan/src/ast/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ pub use mutation::{AstNodeExt, AstNodeListExt, AstSeparatedListExt};
/// bitfield here being twice as large as it needs to cover all nodes as well
/// as all token kinds
#[derive(Clone, Copy, Debug, PartialEq, Eq)]
pub struct SyntaxKindSet<L: Language>([u128; 4], PhantomData<L>);
pub struct SyntaxKindSet<L: Language>([u128; 5], PhantomData<L>);

impl<L> SyntaxKindSet<L>
where
Expand All @@ -50,7 +50,7 @@ where
/// ```compile_fail
/// # use biome_rowan::{SyntaxKindSet, RawSyntaxKind, raw_language::RawLanguage};
/// const EXAMPLE: SyntaxKindSet<RawLanguage> =
/// SyntaxKindSet::<RawLanguage>::from_raw(RawSyntaxKind(512));
/// SyntaxKindSet::<RawLanguage>::from_raw(RawSyntaxKind(640));
/// # println!("{EXAMPLE:?}"); // The constant must be used to be evaluated
/// ```
pub const fn from_raw(kind: RawSyntaxKind) -> Self {
Expand All @@ -60,7 +60,7 @@ where
let shift = kind % u128::BITS as u16;
let mask = 1 << shift;

let mut bits = [0; 4];
let mut bits = [0; 5];
bits[index] = mask;

Self(bits, PhantomData)
Expand All @@ -74,6 +74,7 @@ where
self.0[1] | other.0[1],
self.0[2] | other.0[2],
self.0[3] | other.0[3],
self.0[4] | other.0[4],
],
PhantomData,
)
Expand Down
Loading