feat(lint): migrate first batch of Playwright rules from eslint-plugin-playwright

.changeset/common-lizards-sniff.md

@@ -0,0 +1,21 @@
+---
+"@biomejs/biome": patch
+---
+
+Added 11 new Playwright lint rules to the nursery (from eslint-plugin-playwright).
+
+The following rules are now available:
+
+- [`noPlaywrightMissingAwait`](https://biomejs.dev/linter/rules/no-playwright-missing-await/): Enforce awaiting async Playwright APIs.
+- [`noPlaywrightElementHandle`](https://biomejs.dev/linter/rules/no-playwright-element-handle/): Prefer locators over element handles (`page.$()` and `page.$$()`).
+- [`noPlaywrightEval`](https://biomejs.dev/linter/rules/no-playwright-eval/): Disallow `page.$eval()` and `page.$$eval()` methods.
+- [`noPlaywrightForceOption`](https://biomejs.dev/linter/rules/no-playwright-force-option/): Disallow the `force` option on user interactions.
+- [`noPlaywrightNetworkidle`](https://biomejs.dev/linter/rules/no-playwright-networkidle/): Disallow deprecated `networkidle` wait option.
+- [`noPlaywrightPagePause`](https://biomejs.dev/linter/rules/no-playwright-page-pause/): Disallow `page.pause()` debugging calls in committed code.
+- [`noPlaywrightUselessAwait`](https://biomejs.dev/linter/rules/no-playwright-useless-await/): Disallow unnecessary `await` on synchronous Playwright methods.
+- [`usePlaywrightValidDescribeCallback`](https://biomejs.dev/linter/rules/use-playwright-valid-describe-callback/): Validate describe callback signatures are not async.
+- [`noPlaywrightWaitForNavigation`](https://biomejs.dev/linter/rules/no-playwright-wait-for-navigation/): Prefer modern navigation APIs over deprecated `waitForNavigation()`.
+- [`noPlaywrightWaitForSelector`](https://biomejs.dev/linter/rules/no-playwright-wait-for-selector/): Prefer locators over deprecated `waitForSelector()`.
+- [`noPlaywrightWaitForTimeout`](https://biomejs.dev/linter/rules/no-playwright-wait-for-timeout/): Disallow hard-coded timeouts with `waitForTimeout()`.
+
+Additionally, the existing `noFocusedTests` rule now detects Playwright's `test.only()` pattern, and `noSkippedTests` already handles Playwright's `test.skip()` pattern.

crates/biome_analyze/src/rule.rs

@@ -161,6 +161,8 @@ pub enum RuleSource {
     EslintVitest(&'static str),
     /// Rules from [Eslint Plugin Vue.js](https://eslint.vuejs.org/)
     EslintVueJs(&'static str),
+    /// Rules from [Eslint Plugin Playwright](https://github.com/playwright-community/eslint-plugin-playwright)
+    EslintPlaywright(&'static str),
     /// Rules from [graphql-schema-linter](https://github.com/cjoudrey/graphql-schema-linter)
     GraphqlSchemaLinter(&'static str),
     /// Rules from [Stylelint](https://github.com/stylelint/stylelint)
@@ -195,6 +197,7 @@ impl std::fmt::Display for RuleSource {
                 write!(f, "eslint-plugin-package-json-dependencies")
             }
             Self::EslintPerfectionist(_) => write!(f, "eslint-plugin-perfectionist"),
+            Self::EslintPlaywright(_) => write!(f, "eslint-plugin-playwright"),
             Self::EslintQwik(_) => write!(f, "eslint-plugin-qwik"),
             Self::EslintReact(_) => write!(f, "eslint-plugin-react"),
             Self::EslintReactHooks(_) => write!(f, "eslint-plugin-react-hooks"),
@@ -277,6 +280,7 @@ impl RuleSource {
             | Self::EslintPackageJson(rule_name)
             | Self::EslintPackageJsonDependencies(rule_name)
             | Self::EslintPerfectionist(rule_name)
+            | Self::EslintPlaywright(rule_name)
             | Self::EslintQwik(rule_name)
             | Self::EslintReact(rule_name)
             | Self::EslintReactHooks(rule_name)
@@ -321,6 +325,7 @@ impl RuleSource {
                 format!("package-json-dependencies/{rule_name}")
             }
             Self::EslintPerfectionist(rule_name) => format!("perfectionist/{rule_name}"),
+            Self::EslintPlaywright(rule_name) => format!("playwright/{rule_name}"),
             Self::EslintQwik(rule_name) => format!("qwik/{rule_name}"),
             Self::EslintReact(rule_name) => format!("react/{rule_name}"),
             Self::EslintReactHooks(rule_name) => format!("react-hooks/{rule_name}"),
@@ -377,6 +382,7 @@ impl RuleSource {
             Self::EslintUnusedImports(rule_name) => format!("https://github.com/sweepline/eslint-plugin-unused-imports/blob/master/docs/rules/{rule_name}.md"),
             Self::EslintVitest(rule_name) => format!("https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/{rule_name}.md"),
             Self::EslintVueJs(rule_name) => format!("https://eslint.vuejs.org/rules/{rule_name}"),
+            Self::EslintPlaywright(rule_name) => format!("https://github.com/playwright-community/eslint-plugin-playwright/blob/main/docs/rules/{rule_name}.md"),
             Self::GraphqlSchemaLinter(rule_name) => format!("https://github.com/cjoudrey/graphql-schema-linter?tab=readme-ov-file#{rule_name}"),
             Self::Stylelint(rule_name) => format!("https://github.com/stylelint/stylelint/blob/main/lib/rules/{rule_name}/README.md"),
         }
@@ -456,6 +462,8 @@ pub enum RuleDomain {
     Solid,
     /// Next.js framework rules
     Next,
+    /// Playwright testing library rules
+    Playwright,
     /// Qwik framework rules
     Qwik,
     /// Vue.js framework rules
@@ -474,6 +482,7 @@ impl Display for RuleDomain {
             Self::Test => fmt.write_str("test"),
             Self::Solid => fmt.write_str("solid"),
             Self::Next => fmt.write_str("next"),
+            Self::Playwright => fmt.write_str("playwright"),
             Self::Qwik => fmt.write_str("qwik"),
             Self::Vue => fmt.write_str("vue"),
             Self::Project => fmt.write_str("project"),
@@ -510,6 +519,7 @@ impl RuleDomain {
             ],
             Self::Solid => &[&("solid", ">=1.0.0")],
             Self::Next => &[&("next", ">=14.0.0")],
+            Self::Playwright => &[&("@playwright/test", ">=1.0.0")],
             Self::Qwik => &[
                 &("@builder.io/qwik", ">=1.0.0"),
                 &("@qwik.dev/core", ">=2.0.0"),
@@ -538,6 +548,7 @@ impl RuleDomain {
             ],
             Self::Solid => &[],
             Self::Next => &[],
+            Self::Playwright => &["test", "expect"],
             Self::Qwik => &[],
             Self::Vue => &[],
             Self::Project => &[],
@@ -551,6 +562,7 @@ impl RuleDomain {
             Self::Test => "test",
             Self::Solid => "solid",
             Self::Next => "next",
+            Self::Playwright => "playwright",
             Self::Qwik => "qwik",
             Self::Vue => "vue",
             Self::Project => "project",
@@ -568,11 +580,11 @@ impl FromStr for RuleDomain {
             "test" => Ok(Self::Test),
             "solid" => Ok(Self::Solid),
             "next" => Ok(Self::Next),
+            "playwright" => Ok(Self::Playwright),
             "qwik" => Ok(Self::Qwik),
             "vue" => Ok(Self::Vue),
             "project" => Ok(Self::Project),
             "tailwind" => Ok(Self::Tailwind),
-
             _ => Err("Invalid rule domain"),
         }
     }

crates/biome_diagnostics_categories/src/categories.rs

@@ -182,6 +182,17 @@ define_categories! {
     "lint/nursery/noMultiStr": "https://biomejs.dev/linter/rules/no-multi-str",
     "lint/nursery/noNextAsyncClientComponent": "https://biomejs.dev/linter/rules/no-next-async-client-component",
     "lint/nursery/noParametersOnlyUsedInRecursion": "https://biomejs.dev/linter/rules/no-parameters-only-used-in-recursion",
+    "lint/nursery/noPlaywrightElementHandle": "https://biomejs.dev/linter/rules/no-playwright-element-handle",
+    "lint/nursery/noPlaywrightEval": "https://biomejs.dev/linter/rules/no-playwright-eval",
+    "lint/nursery/noPlaywrightForceOption": "https://biomejs.dev/linter/rules/no-playwright-force-option",
+    "lint/nursery/noPlaywrightMissingAwait": "https://biomejs.dev/linter/rules/no-playwright-missing-await",
+    "lint/nursery/noPlaywrightNetworkidle": "https://biomejs.dev/linter/rules/no-playwright-networkidle",
+    "lint/nursery/noPlaywrightPagePause": "https://biomejs.dev/linter/rules/no-playwright-page-pause",
+    "lint/nursery/noPlaywrightUselessAwait": "https://biomejs.dev/linter/rules/no-playwright-useless-await",
+    "lint/nursery/usePlaywrightValidDescribeCallback": "https://biomejs.dev/linter/rules/use-playwright-valid-describe-callback",
+    "lint/nursery/noPlaywrightWaitForNavigation": "https://biomejs.dev/linter/rules/no-playwright-wait-for-navigation",
+    "lint/nursery/noPlaywrightWaitForSelector": "https://biomejs.dev/linter/rules/no-playwright-wait-for-selector",
+    "lint/nursery/noPlaywrightWaitForTimeout": "https://biomejs.dev/linter/rules/no-playwright-wait-for-timeout",
     "lint/nursery/noProto": "https://biomejs.dev/linter/rules/no-proto",
     "lint/nursery/noReactForwardRef": "https://biomejs.dev/linter/rules/no-react-forward-ref",
     "lint/nursery/noShadow": "https://biomejs.dev/linter/rules/no-shadow",