-
-
Notifications
You must be signed in to change notification settings - Fork 888
feat: sort interface members #7553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
87 commits
Select commit
Hold shift + click to select a range
3c8203b
fix(ROME_CHANGELOG.md): grammar and typo error (#7992)
WuMingDao 47dfc9a
chore(parser): increase size of SyntaxKindSet bitfield (#7994)
ryan-m-walker 549bcd4
fix(RELEASES.md): grammar and typo error (#7993)
WuMingDao 42a1007
fix(html): fix comment detection in Astro frontmatter (#7989)
alissonlauffer a688e62
feat: support html.experimentalFullSupportEnabled for vue with jsx/ts…
lisiur 9f0dd8e
ci: release (#7965)
github-actions[bot] e56cda2
feat(html/svelte): key blocks (#8001)
ematipico 15ff612
chore(parser): increase size of TokenSet (#7997)
ryan-m-walker 84360d3
feat(html/svelte): parsing of new blocks (#8023)
ematipico 0fdc25e
fix(useArrowFunction): make useArrowFunction rule fixer safer (#8009)
tmcw eadcaff
fix(deps): update rust crates (#7889)
renovate[bot] 9a74045
feat(cli): add format errors to GitLab reporter (#8028)
fmajestic 30360ed
fix(html/astro): don't indent Astro frontmatter (#8037)
PFiS1737 7b2708f
fix(html/astro): keep a blank after the frontmatter (#8039)
PFiS1737 99441aa
fix(parse/tailwind): fix lexing `inset-x`, `border-slate-500`, and ot…
dyc3 227019c
fix(parse/css/tailwind): make `@custom-variant` accept selector lists…
dyc3 ce2f813
docs: rules.rs cleanup (#8044)
Netail eb4f400
docs: update documentation + diagnostic for `noBannedTypes` descripti…
Bertie690 90283ad
refactor(deserialize): exact allocation for arrays and maps (#8040)
Conaclos a6337db
feat(parse/tailwind): add benchmark (#7976)
dyc3 528df11
feat(html/svelte): `if/else` syntax (#8031)
ematipico 0c2030e
fix(parse/css/tailwind): make `@custom-variant` accept at-rules like …
dyc3 d2c7e96
chore: enable more rustc lints (#8047)
Conaclos c213d42
ci: trigger benches when formatter changes (#8046)
ematipico 64f1bac
chore(deps): update github-actions (#8048)
renovate[bot] 43e43a6
chore(deps): update dependency eslint to v9.39.1 (#8049)
renovate[bot] 1f77f57
chore(deps): update rust crate jiff to 0.2.16 (#8050)
renovate[bot] 78d9005
chore(deps): update rust crate quote to 1.0.42 (#8051)
renovate[bot] b1ee9ed
chore(deps): update rust crate ureq to 3.1.4 (#8052)
renovate[bot] 3a73252
chore(deps): update rust docker tag to v1.91.0 (#8056)
renovate[bot] 8c1d190
chore(deps): update typescript-eslint monorepo to v8.46.3 (#8057)
renovate[bot] 3af667c
feat(parse/html): support vue directive syntax (#7673)
dyc3 ced55ae
fix(lsp): biome project watcher (#8058)
ematipico 0513f6b
fix(no_unknown_attribute): added support for new dom attributes (#8064)
dibashthapa 6333003
feat(biome_js_analyze): implement useArraySortCompare (#8065)
Netail ee4c890
ci: release (#8003)
github-actions[bot] 0b248e3
refactor(cli/logging): removed duplication in setup_cli_subscriber(..…
JadKHaddad 206dac0
perf(parse/tailwind): use compact trie for lexing base names instead …
dyc3 18c129c
feat(biome_graphql_analyze): implement `useConsistentGraphqlDescripti…
Netail c19bcde
fix: remove unexpected new line when adding a readonly class property…
YTomm 3256a98
feat(html/analyze): add useVueValidVBind (#8060)
dyc3 c68c0f2
fix(noDuplicateTestHook): detect more test function defintions (#7287)
ToBinio e60ade8
fix(noParametersOnlyUsedInRecursion): compare bindings for recursion …
matanshavit 5e5b45e
feat(html/analyze): add `useVueValidVIf`, `useVueValidVElseIf`, `useV…
dyc3 96a8051
refactor(lint): refactor NoParametersOnlyUsedInRecursion (#7970)
matanshavit b86bd62
fix(parse/html/vue): fix modifier list parser aggressively parsing to…
dyc3 9851fda
feat(js_analyze): implement noForIn (#8085)
Netail ac86030
fix(noNestedTernary): detect nested ternaries wrapped in parentheses …
matanshavit 2db05b2
refactor: migrate to schemars v1 (#8087)
ematipico 7675e12
feat(graphql_analyze): add `useUniqueGraphqlOperationName` (#8013)
Jayllyz fa94f9c
chore: regression schemars v1 (#8092)
ematipico 42c3020
refactor(core): actions and pull diagnostics (#8082)
ematipico 60a25f8
chore: enable oidc publishing (#8074)
ematipico 503e6fc
chore: expose schema generation function (#8093)
ematipico b89a205
feat: add useSpread rule (#7681)
kedevked aaa7896
chore(core): add CSS variant information to the source file (#8095)
ematipico 0bb1d63
feat(schema): add docs URLs to rule description (#8098)
Jayllyz 5a184d1
feat(js_analyze): implement useFind (#8100)
Netail b768b0e
feat(biome_js_analyze): align no_unused_private_class_members_with_se…
vladimir-ivanov 741aad4
feat(analyze): implement `noSyncScripts` (#8108)
Netail 084c1dd
fix(noInvalidUseBeforeDeclaration): don't report use before ambient v…
Conaclos b74bdc5
fix(noInvalidUseBeforeDeclaration): handle class, enum, import-equals…
Conaclos 72dfab0
fix(useReactFunctionComponents): handle class expressions with compon…
lucasweng 79040d0
feat(lint/vue): add `noVueVIfWithVFor`, `useVueHyphenatedAttributes` …
dyc3 1fbed61
chore(deps): update github-actions (#8121)
renovate[bot] 0862af3
chore(deps): update dependency @types/node to v22.19.1 (#8122)
renovate[bot] 1d68b90
chore(deps): update dependency rust to v1.91.1 (#8123)
renovate[bot] 9fe5a73
chore(deps): update taiki-e/install-action action to v2.62.52 (#8126)
renovate[bot] be60066
chore(deps): update typescript-eslint monorepo to v8.46.4 (#8127)
renovate[bot] 154b87a
fix(biome_js_analyze): fix useValidLang rejecting BCP 47 language tag…
93140a2
fix(deps): update @biomejs packages (#8129)
renovate[bot] 3a90fa4
fix(deps): update rust crates (#8130)
renovate[bot] c0131ea
chore(deps): update rust crate schemars to 1.1.0 (#8124)
renovate[bot] ef55974
chore(deps): update rust crate windows to 0.62.2 (#8053)
renovate[bot] 523a6e4
chore(deps): update @biomejs packages (major) (#8131)
renovate[bot] 970d0e2
chore(deps): update dependency @types/node to v24 (#8132)
renovate[bot] da56e13
chore: schema regression rule domains (#8133)
ematipico 08731c2
chore: disable docstrings in coderabbit (#8134)
ematipico 7cbb600
ci: release (#8076)
github-actions[bot] 9d7af12
chore: remove gold sponsor (#8135)
ematipico 0342459
fix: next namespace (#8142)
Netail 902f57e
fix(schema): domains and feature kind (#8147)
ematipico c79d865
docs(lint/html): fix some html rule docs that mess up markdown render…
dyc3 e5a66f5
fix(noInvalidUseBeforeDeclaration): ignore valid use before declarati…
Conaclos 3a995fc
feat: sort interface members
hamirmahal 8800fa0
make sort interface members an assist action, not
hamirmahal 1eabb32
rebase and fix changeset
ematipico File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| --- | ||
| "@biomejs/biome": patch | ||
| --- | ||
|
|
||
| Fixed [#8148](https://github.com/biomejs/biome/issues/8148). [`noInvalidUseBeforeDeclaration`](https://biomejs.dev/linter/rules/no-invalid-use-before-declaration/) no longer reports some valid use before declarations. | ||
|
|
||
| The following code is no longer reported as invalid: | ||
|
|
||
| ```ts | ||
| class classA { | ||
| C = C; | ||
| } | ||
| const C = 0; | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| --- | ||
| "@biomejs/biome": minor | ||
| --- | ||
|
|
||
| Added a new assist action `useSortedInterfaceMembers` that sorts TypeScript interface members, for readability. | ||
|
|
||
| It includes an autofix. | ||
|
|
||
| Invalid example. | ||
|
|
||
| ```ts,expect_diagnostic | ||
| interface MixedMembers { | ||
| z: string; | ||
| a: number; | ||
| (): void; | ||
| y: boolean; | ||
| } | ||
| ``` | ||
|
|
||
| Valid example (after using the assist). | ||
|
|
||
| ```ts | ||
| interface MixedMembers { | ||
| a: number; | ||
| y: boolean; | ||
| z: string; | ||
| (): void; | ||
| } | ||
| ``` | ||
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| name: Benchmarks Tailwind | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| pull_request: | ||
| types: [opened, synchronize] | ||
| branches: | ||
| - main | ||
| - next | ||
| paths: | ||
| - "Cargo.lock" | ||
| - "crates/biome_tailwind_parser/**/*.rs" | ||
| - "crates/biome_tailwind_*/**/*.rs" | ||
| - "crates/biome_rowan/**/*.rs" | ||
| - "crates/biome_parser/**/*.rs" | ||
| push: | ||
| branches: | ||
| - main | ||
| - next | ||
| paths: | ||
| - "Cargo.lock" | ||
| - "crates/biome_tailwind_parser/**/*.rs" | ||
| - "crates/biome_tailwind_*/**/*.rs" | ||
| - "crates/biome_rowan/**/*.rs" | ||
| - "crates/biome_parser/**/*.rs" | ||
|
|
||
| env: | ||
| RUST_LOG: info | ||
|
|
||
| jobs: | ||
| bench: | ||
| permissions: | ||
| contents: read | ||
| pull-requests: write | ||
| name: Bench | ||
| runs-on: depot-ubuntu-24.04-arm-16 | ||
| strategy: | ||
| matrix: | ||
| package: | ||
| - biome_tailwind_parser | ||
|
|
||
| steps: | ||
| - name: Checkout PR Branch | ||
| uses: actions/checkout@08eba0b27e820071cde6df949e0beb9ba4906955 # v4.3.0 | ||
| with: | ||
| ref: ${{ github.event.pull_request.head.sha || github.sha }} | ||
|
|
||
| - name: Install toolchain | ||
| uses: moonrepo/setup-rust@ede6de059f8046a5e236c94046823e2af11ca670 # v1.2.2 | ||
| with: | ||
| channel: stable | ||
| cache-target: release | ||
| bins: cargo-codspeed | ||
| cache-base: main | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Compile | ||
| timeout-minutes: 20 | ||
| run: cargo codspeed build -p ${{ matrix.package }} | ||
| env: | ||
| CARGO_BUILD_JOBS: 3 # Default is 4 (equals to the vCPU count of the runner), which leads OOM on cargo build | ||
|
|
||
| - name: Run the benchmarks | ||
| uses: CodSpeedHQ/action@76578c2a7ddd928664caa737f0e962e3085d4e7c # v3.8.1 | ||
| timeout-minutes: 50 | ||
| with: | ||
| run: cargo codspeed run | ||
| token: ${{ secrets.CODSPEED_TOKEN }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion | 🟠 Major
Improve changeset description for end-user clarity.
The current description is vague. Per past feedback, add the rule/assist name and brief explanation so end users understand what changed. Include a code example showing the behaviour.
Reference the
.changeset/bright-tires-report.mdformat as a good example.🤖 Prompt for AI Agents