-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix(noExtraBooleanCast): preserve parentheses to maintain operator precedence #7244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ematipico
merged 21 commits into
biomejs:main
from
JeetuSuthar:fix-boolean-cast-parentheses
Aug 22, 2025
Merged
Changes from 2 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
a14fcca
test: add test case for noExtraBooleanCast parentheses preservation
JeetuSuthar 4e5ffe6
docs: improve changeset description following guidelines
JeetuSuthar 57b2305
docs: update changeset to clarify test-only addition per review
JeetuSuthar 32ba1e7
chore: remove changeset .
JeetuSuthar 27c1c87
fix: preserve parentheses in noExtraBooleanCast rule when removing Bo…
JeetuSuthar 3b2aebe
[autofix.ci] apply automated fixes
autofix-ci[bot] 2196fdc
fix: add support for logical and sequence expressions in parentheses …
JeetuSuthar 040defa
Resolve merge conflict and integrate CodeRabbit review feedback
JeetuSuthar 600d5fa
Fix unused imports warning with allow attribute
JeetuSuthar 0500c6b
[autofix.ci] apply automated fixes
autofix-ci[bot] 1617b75
Fix unused imports warning with allow attribute
JeetuSuthar d2e9574
refactor action function and remove test files
JeetuSuthar 4fedd9f
Fix clippy lint: use #[expect] instead of #[allow]
JeetuSuthar fbac80e
[autofix.ci] apply automated fixes
autofix-ci[bot] 7a79776
test: update
JeetuSuthar 3e8c850
Merge update
JeetuSuthar 70066e5
fix
JeetuSuthar 81ad304
Merge branch 'main' into fix-boolean-cast-parentheses
ematipico e1f57f3
Update .changeset/fix-boolean-cast-parentheses.md
JeetuSuthar 4f07e18
Remove test files that shouldn't be in the PR
JeetuSuthar 196f806
Merge remote changes and remove unwanted test files
JeetuSuthar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@biomejs/biome": patch | ||
| --- | ||
|
|
||
| Fixed [#7225](https://github.com/biomejs/biome/issues/7225): Added test case for noExtraBooleanCast rule to verify parentheses preservation in `!Boolean(b0 && b1)` expressions. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.