feat(lint): Implement noImplicitAnyLet
#715
Merged
+440
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Project
|
WIll fix conflicts. |
TaKO8Ki
force-pushed
the
add-noImplicitAnyLet
branch
from
b14ba5f to
829e4a8
Compare
TaKO8Ki
force-pushed
the
add-noImplicitAnyLet
branch
from
8a8892b to
3ec0556
Compare
unvalley
reviewed
Nov 14, 2023
| declare_rule! { | ||
| /// Disallow use of implicit `any` type on variable declarations. | ||
| /// | ||
| /// Typescript variable declaration without any `type` or `initialization` can cause issue later in the code. |
There was a problem hiding this comment.
This @Conaclos 's suggestion is good to add.
ref: #395 (comment)
Suggested change
| /// Typescript variable declaration without any `type` or `initialization` can cause issue later in the code. | |
| /// TypeScript variable declaration without any type annotation and initialization have the `any` type. | |
| /// The any type in TypeScript is a dangerous “escape hatch” from the type system. | |
| /// Using any disables many type checking rules and is generally best used only as a last resort or when prototyping code. | |
| /// TypeScript’s `--noImplicitAny` compiler option doesn't report this case. |
After fixing this, you need to run just codegen again 🙏
|
@TaKO8Ki Thanks for completing it! We can merge this after updating above suggestion. |
unvalley
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #389
closes #395
This implements a new rule to restrict the usage of variables without any type or initialisation in TS.
ref: https://www.typescriptlang.org/tsconfig#noImplicitAny
I have taken over #395. Thank you for the work @b4s36t4.
Test Plan
All existing tests should pass. #395 has added some test cases for valid and invalid situation and I've improved them.
In addition, I have corrected all the issues pointed out in #395 for now.