Fix parsing maxAllowedComplexity
#646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Linter
|
That's a bug from our end. We used the incorrect APIs to represent the information. |
ematipico
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #643.
Summary
So apparently there's a confusing behavior where the
SyntaxNodeof aJsonNumberValuemay contain a trailing space. If it does, calling.to_string()on the syntax node will include the space, causingu8::from_str()to fail. Calling.text()directly on the value doesn't have this issue.To be honest, it feels like this may be a workaround to a deeper issue, so I'm not entirely sure this is the right fix. Because of this, I also have not yet created a test for it. Is the possibility for trailing spaces in syntax nodes an expected behavior?
Test Plan
I think an extra unit test should be created for this, since it's quite surprising behavior. But right now I'm more concerned about how similar issues could be prevented from (re)occurring. But the right action here depends on whether the spaces in syntax nodes are intentional or not.