You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure if it is the best way how to handle it.
Because now we have an invariant over a parameter and we have to unwrap it for cases where an identifier is invalid.
We can try to introduce more a comprehensive syntax for part and highlight.
what do you think?
I'm not sure if it is the best way how to handle it. Because now we have an invariant over a parameter and we have to unwrap it for cases where an identifier is invalid. We can try to introduce more a comprehensive syntax for part and highlight. what do you think?
Having worked on a CSS parser before, I know their grammar is very strict, and most of the time they apply rules to very specific parts of the grammar, e.g. calc, which is a function but it has very strict rules about what's inside it
My gut feeling tells me that we should implement specific grammar/parsing whenever we can, and try to avoid applying "generic" functions/nodes/patterns whenever we can.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Change
part
andhighlight
syntax, they have identifies as a parameter:https://developer.mozilla.org/en-US/docs/Web/CSS/::part
https://developer.mozilla.org/en-US/docs/Web/CSS/::highlight
Test Plan
cargo test