Conversation
CodSpeed Performance ReportMerging #5056 will not alter performanceComparing Summary
|
94eadb3 to
5273183
Compare
Contributor
Author
|
Regarding the failing tests:
|
5273183 to
90d257b
Compare
Contributor
Author
|
I've removed the 4 failing tests temporarily because I would rather get these in the repo to help avoid regressions in future PRs, and the underlying issue preventing me from fixing them requires some closer examination. |
ematipico
approved these changes
Feb 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This imports all the HTML tests from prettier into our snapshot tests. It excludes some tests that rely on prettier's infra (eg. the "cursor" tests). At the time of writing, only 4 of prettier's tests outright fail, and a large portion of the imported tests don't match prettier's output.
Caution
This PR is stacked on the following PRs. Do not merge it without merging the others and rebasing this branch. To review this PR, look at the last commit only.
Test Plan
CI should pass except for the 4 tests mentioned above.