Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove organizeImports #4788

Merged
merged 4 commits into from
Dec 26, 2024
Merged

refactor: remove organizeImports #4788

merged 4 commits into from
Dec 26, 2024

Conversation

ematipico
Copy link
Member

@ematipico ematipico commented Dec 24, 2024

Summary

Part of #4662

This PR removes the top-level organizeImports configuration.

The Assist is now stable, and users should use that to put actions.

The PR also adds a migration, in case users have the import sorting disabled.

Test Plan

Updated existing tests

@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project A-Linter Area: linter A-Tooling Area: internal tools A-LSP Area: language server protocol L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis labels Dec 24, 2024
Copy link

codspeed-hq bot commented Dec 24, 2024

CodSpeed Performance Report

Merging #4788 will not alter performance

Comparing refactor/organize-imports (8efd8f1) with next (4f4cafb)

Summary

✅ 97 untouched benchmarks

@ematipico ematipico merged commit 93d1e23 into next Dec 26, 2024
12 checks passed
@ematipico ematipico deleted the refactor/organize-imports branch December 26, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI A-Diagnostic Area: diagnostocis A-Linter Area: linter A-LSP Area: language server protocol A-Project Area: project A-Tooling Area: internal tools L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant