Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(linter): add noNoninteractiveElementInteractions rule #4358

Merged
merged 16 commits into from
Jan 3, 2025
Merged

feat(linter): add noNoninteractiveElementInteractions rule #4358

merged 16 commits into from
Jan 3, 2025

Conversation

tunamaguro
Copy link
Contributor

@tunamaguro tunamaguro commented Oct 21, 2024 •
edited
Loading

Summary

Implement jsx-a11y/no-noninteractive-element-interactions

Close #3936

Test Plan

@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis labels Oct 21, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 21, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #4358 will improve performances by 6.51%

Comparing tunamaguro:impl-noNoninteractiveElementInteractions (df1d58b) with main (e0937d6)

Summary

⚡ 1 improvements
✅ 96 untouched benchmarks

Benchmarks breakdown

Benchmark main tunamaguro:impl-noNoninteractiveElementInteractions Change
⚡ react.production.min_3378072959512366797.js[uncached] 2.2 ms 2.1 ms +6.51%

@tunamaguro tunamaguro force-pushed the impl-noNoninteractiveElementInteractions branch from 02a8329 to 5d53042 Compare October 22, 2024 12:26
@github-actions github-actions bot added the A-Parser Area: parser label Jan 3, 2025
ematipico
ematipico approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased the PR, and updated its code to use the new APIs

@ematipico ematipico merged commit a658a29 into biomejs:main Jan 3, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyc3 dyc3 dyc3 left review comments

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
A-CLI Area: CLI A-Diagnostic Area: diagnostocis A-Linter Area: linter A-Parser Area: parser A-Project Area: project L-JavaScript Language: JavaScript and super languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

📎 Implement jsx-a11y/no-noninteractive-element-interactions
3 participants
@tunamaguro @ematipico @dyc3