Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(useFilenamingConvention): use the Cases bit flags for filename cases #4316

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

Conaclos
Copy link
Member

@Conaclos Conaclos commented Oct 17, 2024

Summary

This brings the implementation of useFilenamingConvention closer to the implementation of useNamingConvention. We now use internally the Cases bit flags.
This should marginally improve file case checking performance.

Also, I had to fix some bugs in biome_deserialize_macros related to validators.

Test Plan

CI must pass.

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Oct 17, 2024
@Conaclos Conaclos merged commit 7fffb27 into main Oct 17, 2024
12 checks passed
@Conaclos Conaclos deleted the conaclos/useFilenamingConvention-refactor branch October 17, 2024 09:43
Copy link

codspeed-hq bot commented Oct 17, 2024

CodSpeed Performance Report

Merging #4316 will not alter performance

Comparing conaclos/useFilenamingConvention-refactor (5f042a8) with main (ea7d35c)

Summary

✅ 101 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant