Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(linter): rename useExplicitFunctionReturnType to `useExplicit… #4261

Merged

Conversation

kaykdm
Copy link
Contributor

@kaykdm kaykdm commented Oct 12, 2024

…Type`

Summary

related: #2017
rename useExplicitFunctionReturnType to useExplicitType
Before implementing the typescript-eslint/explicit-module-boundary-types rule, I renamed it for better accuracy, as discussed in the issue here .

Test Plan

@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis labels Oct 12, 2024
Copy link

codspeed-hq bot commented Oct 12, 2024

CodSpeed Performance Report

Merging #4261 will degrade performances by 8.24%

Comparing kaykdm:rename-use-explict-function-return-type (cd632ba) with main (773f5b0)

Summary

❌ 1 regressions
✅ 104 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main kaykdm:rename-use-explict-function-return-type Change
big5-added_15586211152145260264.json[uncached] 547.4 µs 596.5 µs -8.24%

@ematipico ematipico merged commit 3cf20eb into biomejs:main Oct 12, 2024
11 of 12 checks passed
@kaykdm kaykdm deleted the rename-use-explict-function-return-type branch October 12, 2024 06:26
@Conaclos
Copy link
Member

@kaykdm The rule you implemented is not meant to cover both all cases of #2017? Why did you rename the rule then?

@kaykdm
Copy link
Contributor Author

kaykdm commented Oct 15, 2024

@Conaclos
Sorry for the late response.

  • I noticed the issue title after implementing the typescript-eslint/explicit-function-return-type rule and assumed that the rule name was already decided.
  • I'm planning to implement the typescript-eslint/explicit-module-boundary-types rule, so I thought it would make sense to rename the rule before proceeding with its implementation.

I don't mind reverting the rename PR if you'd prefer me to include the rename chore in the first PR with the new rule.

@Conaclos
Copy link
Member

@kaykdm I am unsure to understand what you mean. Do you want to extend the current rule to cover #2017?

@kaykdm
Copy link
Contributor Author

kaykdm commented Oct 16, 2024

Do you want to extend the current rule to cover #2017?

@Conaclos
Yes, that was my plan, and I thought that was your plan too. If you think that we should separate the rule, that would be fine for me as well.

@Conaclos
Copy link
Member

Thanks for the response, I will assign the task to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI A-Diagnostic Area: diagnostocis A-Linter Area: linter A-Project Area: project L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants