feat(format/grit): add basic formatting for where pattern #4095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #4095 will not alter performanceComparing Summary
|
ematipico
reviewed
Sep 26, 2024
Co-authored-by: Emanuele Stoppa <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
….7.0 (biomejs#4129) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
… diagnostics (biomejs#4112) Co-authored-by: Emanuele Stoppa <[email protected]>
github-actions
bot
added
A-CLI
branberry
changed the title
branberry
changed the title
dyc3
reviewed
Oct 5, 2024
dyc3
approved these changes
Oct 5, 2024
ah-yu
reviewed
Oct 6, 2024
crates/biome_grit_formatter/tests/specs/grit/patterns/options.json
Outdated
Show resolved
Hide resolved
ematipico
reviewed
Oct 7, 2024
Comment on lines
13
to
22
| match definition { | ||
| Ok(definition) => { | ||
| join.entry( | ||
| definition.syntax(), | ||
| &format_or_verbatim(definition.format()), | ||
| ); | ||
| } | ||
| Err(_) => (), | ||
| } | ||
| } |
There was a problem hiding this comment.
No need for using the match. You can simply do
let definition = definition?;There was a problem hiding this comment.
Thank you for this! Rust newbie here, so I appreciate this kind of input.
ah-yu
approved these changes
Oct 8, 2024
arendjr
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a basic formatting rule for the
wherepattern#2455
Test Plan
Snapshot test demonstrates the intended formatting behavior.