Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(html): resolve format options #4017

Merged
merged 1 commit into from
Sep 22, 2024
Merged

feat(html): resolve format options #4017

merged 1 commit into from
Sep 22, 2024

Conversation

dyc3
Copy link
Contributor

@dyc3 dyc3 commented Sep 20, 2024 •
edited
Loading

Summary

This PR implements resolving formatter options for HTML.

Test Plan

Tested manually on a local version of the playground. Planning to add tests. I couldn't find an easy way to add snapshot tests for this.

@github-actions github-actions bot added A-Project Area: project A-Formatter Area: formatter L-HTML Language: HTML labels Sep 20, 2024
@dyc3 dyc3 marked this pull request as ready for review September 20, 2024 20:20
@dyc3 dyc3 requested review from a team September 20, 2024 20:24
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 20, 2024

CodSpeed Performance Report

Merging #4017 will improve performances by 9.11%

Comparing 09-18-feat_html_resolve_format_options (1688110) with main (83626d9)

Summary

⚡ 2 improvements
✅ 105 untouched benchmarks

Benchmarks breakdown

Benchmark main 09-18-feat_html_resolve_format_options Change
⚡ dojo_11880045762646467684.js[cached] 8.4 ms 7.9 ms +6.06%
⚡ db_17847247775464589309.json[cached] 13.9 ms 12.8 ms +9.11%

@dyc3 dyc3 mentioned this pull request Sep 21, 2024
Open
@dyc3 dyc3 merged commit b3724b2 into main Sep 22, 2024
16 checks passed
@dyc3 dyc3 deleted the 09-18-feat_html_resolve_format_options branch September 22, 2024 12:19
@WomB0ComB0 WomB0ComB0 mentioned this pull request Nov 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
A-Formatter Area: formatter A-Project Area: project L-HTML Language: HTML
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dyc3 @ematipico