Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grit): fix node walking #3988

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

arendjr
Copy link
Contributor

@arendjr arendjr commented Sep 19, 2024

Summary

Due to a bug in our Grit node cursor, contains queries would report false positives when the matched node was contained in a sibling instead of inside the node itself. This is the issue we witnessed when drafting the 1.9 release notes, @Conaclos.

Test Plan

Test added.

@arendjr arendjr requested a review from a team September 19, 2024 11:34
@arendjr arendjr merged commit 41ec03e into biomejs:main Sep 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant