test(format/html): reenable snapshot tests #3979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-CLI
CodSpeed Performance ReportMerging #3979 will degrade performances by 7.58%Comparing Summary
Benchmarks breakdown
|
dyc3
force-pushed
the
09-18-test_format_html_reenable_snapshot_tests
branch
from
4063ead
to
300b22a
Compare
|
I'm gonna go ahead and merge this to unblock some other PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Turns out that the snapshot tests were silently disabled since the 1.9.0 release.
This PR also reorganizes the html snapshot tests to match other languages.
Caution
This PR is stacked on the following PRs. Do not merge it without merging the others and rebasing this branch. To review this PR, look at the last commit only.
experimental-htmlfeature flag to enable html file handler #3967Test Plan
Added a panic when a spec test fails to execute.