Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lsp): code actions capabilities #3971

Merged
merged 1 commit into from
Sep 18, 2024
Merged

fix(lsp): code actions capabilities #3971

merged 1 commit into from
Sep 18, 2024

Conversation

ematipico
Copy link
Member

Summary

This PR is a follow-up of #3731

The reason why that PR failed is because we forgot to add other code actions required for lint rules to work.

This PR adds those actions.

Test Plan

I manually tested the new code.

I can still see the code actions emitted by the lint rules (fix and suppression), and the safe fixes are applied on save.

When, for example, source.fixAll.biome is set to false, it isn't applied, which is what we want.

@ematipico ematipico requested review from a team September 18, 2024 15:08
@github-actions github-actions bot added A-Linter Area: linter A-LSP Area: language server protocol A-Changelog Area: changelog labels Sep 18, 2024
Copy link

codspeed-hq bot commented Sep 18, 2024

CodSpeed Performance Report

Merging #3971 will degrade performances by 6.02%

Comparing fix/lsp-code-actions (f53e5e4) with main (0ca9b69)

Summary

❌ 1 regressions
✅ 106 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix/lsp-code-actions Change
dojo_11880045762646467684.js[cached] 8 ms 8.5 ms -6.02%

@ematipico ematipico merged commit 756dd38 into main Sep 18, 2024
14 of 15 checks passed
@ematipico ematipico deleted the fix/lsp-code-actions branch September 18, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter A-LSP Area: language server protocol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants