Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parser/html): handle script and style tags #3970

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

dyc3
Copy link
Contributor

@dyc3 dyc3 commented Sep 18, 2024

Summary

This PR aims to handle <script> and <style> tags as minimally as possible in order to not crash and burn. It intentionally does not attempt to do any embedded language parsing or formatting. This is pretty much just to be able to parse all the prettier tests.

Test Plan

Added tests.

@github-actions github-actions bot added A-Parser Area: parser L-HTML Language: HTML labels Sep 18, 2024
@dyc3 dyc3 force-pushed the 09-17-feat_parser_html_handle_script_and_style_tags branch from 00083fe to a85b508 Compare September 18, 2024 14:13
@dyc3 dyc3 marked this pull request as draft September 18, 2024 14:21
Copy link

codspeed-hq bot commented Sep 18, 2024

CodSpeed Performance Report

Merging #3970 will not alter performance

Comparing 09-17-feat_parser_html_handle_script_and_style_tags (2362a8b) with main (0ca9b69)

Summary

✅ 107 untouched benchmarks

@dyc3 dyc3 force-pushed the 09-17-feat_parser_html_handle_script_and_style_tags branch from a85b508 to 0c80725 Compare September 18, 2024 14:42
@dyc3 dyc3 marked this pull request as ready for review September 18, 2024 14:44
@dyc3 dyc3 requested review from a team September 18, 2024 14:44
@dyc3 dyc3 force-pushed the 09-17-feat_parser_html_handle_script_and_style_tags branch from 0c80725 to 2362a8b Compare September 18, 2024 14:49
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

@dyc3 dyc3 merged commit ad1a744 into main Sep 18, 2024
14 checks passed
@dyc3 dyc3 deleted the 09-17-feat_parser_html_handle_script_and_style_tags branch September 18, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Parser Area: parser L-HTML Language: HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants