Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(format/html): fix doctype formatting #3961

Merged
merged 1 commit into from
Sep 18, 2024
Merged

fix(format/html): fix doctype formatting #3961

merged 1 commit into from
Sep 18, 2024

Conversation

dyc3
Copy link
Contributor

@dyc3 dyc3 commented Sep 17, 2024 •
edited
Loading

Summary

This PR fixes doctype directive formatting so that it matches prettier.

Note

This PR probably doesn't work without:

Test Plan

Added tests.

@github-actions github-actions bot added A-Formatter Area: formatter L-HTML Language: HTML labels Sep 17, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 17, 2024

CodSpeed Performance Report

Merging #3961 will not alter performance

Comparing 09-17-fix_format_html_fix_doctype_formatting (706cb7f) with main (e3b6faf)

Summary

✅ 107 untouched benchmarks

chansuke
chansuke approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@chansuke chansuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@dyc3 dyc3 merged commit 1599555 into main Sep 18, 2024
16 checks passed
@dyc3 dyc3 deleted the 09-17-fix_format_html_fix_doctype_formatting branch September 18, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chansuke chansuke chansuke approved these changes

Assignees
No one assigned
Labels
A-Formatter Area: formatter L-HTML Language: HTML
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dyc3 @chansuke