fix(format/html): keep single quotes if string contains a double quote #3960

dyc3 · 2024-09-17T16:47:09Z

Summary

This PR makes it so that we keep single quotes but only when the string contains a ".

Added a test.

codspeed-hq · 2024-09-17T17:24:53Z

_{Comparing 09-17-fix_format_html_keep_single_quotes_if_string_contains_a_double_quote (9b37249) with main (e3b6faf)}

⚡ 1 improvements
❌ 1 regressions
✅ 105 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

	Benchmark	`main`	`09-17-fix_format_html_keep_single_quotes_if_string_contains_a_double_quote`	Change
❌	`big5-added_15586211152145260264.json[cached]`	438.2 µs	548.6 µs	-20.12%
⚡	`db_17847247775464589309.json[cached]`	13.8 ms	12.8 ms	+7.3%

fix(format/html): keep single quotes if string contains a double quote

9b37249

github-actions bot added A-Formatter Area: formatter L-HTML Language: HTML labels Sep 17, 2024

dyc3 requested review from a team September 17, 2024 17:00

Conaclos approved these changes Sep 17, 2024

View reviewed changes

dyc3 merged commit 806e2af into main Sep 17, 2024
14 of 15 checks passed

dyc3 deleted the 09-17-fix_format_html_keep_single_quotes_if_string_contains_a_double_quote branch September 17, 2024 21:00