Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useFilenamingConvention): allow leading digits in lower-like cases #3957

Merged

Conversation

Conaclos
Copy link
Member

@Conaclos Conaclos commented Sep 17, 2024

Summary

Fix #3952
Leading ASCII digits inside a name are now considered as lowercase characters.
2024-09-17-filename, 2024_09_17_filename, 20240917FileName and 20240917filename are recognized as kebab-case, snake_case, camelCase and lowercase respectively.
2024FILENAME and 2024_FILE_NAME are not recognized as UPPERCASE and CONSTANT_CASE.

Test Plan

I updated the changed snapshot.

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Sep 17, 2024
@Conaclos Conaclos force-pushed the conaclos/useFilenamingConvention-allow-number-in-lowercase-like branch from 46f4581 to bec86ba Compare September 17, 2024 14:44
@github-actions github-actions bot added the A-Changelog Area: changelog label Sep 17, 2024
Copy link

codspeed-hq bot commented Sep 17, 2024

CodSpeed Performance Report

Merging #3957 will degrade performances by 7.52%

Comparing conaclos/useFilenamingConvention-allow-number-in-lowercase-like (568cd95) with main (e1851e2)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 104 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main conaclos/useFilenamingConvention-allow-number-in-lowercase-like Change
pure_9395922602181450299.css[cached] 3.6 ms 3.4 ms +6.41%
router_17129688031671448157.ts[cached] 2.2 ms 2.1 ms +6.95%
db_17847247775464589309.json[uncached] 15.1 ms 16.3 ms -7.52%

@Conaclos Conaclos force-pushed the conaclos/useFilenamingConvention-allow-number-in-lowercase-like branch from bec86ba to 568cd95 Compare September 17, 2024 15:21
@Conaclos Conaclos merged commit e3b6faf into main Sep 17, 2024
14 checks passed
@Conaclos Conaclos deleted the conaclos/useFilenamingConvention-allow-number-in-lowercase-like branch September 17, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💅 useFilenamingConvention false positives on number-prefixed and bracket-wrapped files
1 participant