Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lsp): apply .editorconfig options #3948

Merged
merged 1 commit into from
Sep 16, 2024
Merged

fix(lsp): apply .editorconfig options #3948

merged 1 commit into from
Sep 16, 2024

Conversation

ematipico
Copy link
Member

Summary

Closes #3923

I also did some small refactor the make the code a bit more DRY.

Test Plan

I tested the changes locally

@ematipico ematipico requested review from a team September 16, 2024 16:07
@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project A-LSP Area: language server protocol A-Changelog Area: changelog labels Sep 16, 2024
Copy link
Contributor

@dyc3 dyc3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codspeed-hq bot commented Sep 16, 2024

CodSpeed Performance Report

Merging #3948 will not alter performance

Comparing fix/editorconfig-lsp (c0628dd) with main (2eb6faa)

Summary

✅ 107 untouched benchmarks

@ematipico ematipico merged commit 7aae85e into main Sep 16, 2024
15 checks passed
@ematipico ematipico deleted the fix/editorconfig-lsp branch September 16, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-CLI Area: CLI A-LSP Area: language server protocol A-Project Area: project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📝 editorconfig: max_line_length is ignored when using LSP
2 participants