Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(noUndeclaredDependencies): ignore invalid package names, bun import, and recognize Definitely Typed #3893

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

Conaclos
Copy link
Member

Summary

Fix #3874
Fix #3872

We now ensure that the package name is valid before checking if it is a dependency.
Note that I deliberately accepted some invalid package names (package names starting with an underscore and package name with uppercase character) in order to catch users' typo errors.

We also ignore bun imports.
This looks fair because the NPM module named bun is from the bun runtime.

Test Plan

I added some tests.

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Sep 14, 2024
@Conaclos Conaclos changed the title fix: ignore non-valid package name, bun imports, and recognize Definitely Typed fix(noUndeclaredDependencies): ignore invalid package names, bun import, and recognize Definitely Typed Sep 14, 2024
@Conaclos Conaclos requested review from a team September 14, 2024 17:20
@Conaclos Conaclos force-pushed the conaclos/noUndeclaredDependencies branch from 3a55281 to ab3a0f5 Compare September 14, 2024 17:21
Copy link

codspeed-hq bot commented Sep 14, 2024

CodSpeed Performance Report

Merging #3893 will improve performances by 22.83%

Comparing conaclos/noUndeclaredDependencies (ab3a0f5) with main (30e238d)

Summary

⚡ 2 improvements
✅ 105 untouched benchmarks

Benchmarks breakdown

Benchmark main conaclos/noUndeclaredDependencies Change
router_17129688031671448157.ts[cached] 2.2 ms 2.1 ms +7.86%
big5-added_15586211152145260264.json[cached] 537.8 µs 437.8 µs +22.83%

@Conaclos Conaclos merged commit 140d766 into main Sep 15, 2024
15 checks passed
@Conaclos Conaclos deleted the conaclos/noUndeclaredDependencies branch September 15, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
1 participant