Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser/html): correctly lex tag names and attribute names #3853

Merged

Conversation

dyc3
Copy link
Contributor

@dyc3 dyc3 commented Sep 11, 2024

Summary

This PR fixes the lexing of html tag names and attribute names to allow all the characters defined in the HTML spec.

This should fix the errors we were seeing in our ecosystem CI.

Test Plan

See: https://html.spec.whatwg.org/#elements-2

Also added some unit tests.

@github-actions github-actions bot added the L-HTML Language: HTML label Sep 11, 2024
Copy link

codspeed-hq bot commented Sep 11, 2024

CodSpeed Performance Report

Merging #3853 will degrade performances by 8.08%

Comparing 09-10-fix_parser_html_correctly_lex_tag_names_and_attribute_names (663a823) with main (83e5cef)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 104 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main 09-10-fix_parser_html_correctly_lex_tag_names_and_attribute_names Change
big5-added_15586211152145260264.json[cached] 828.7 µs 434.5 µs +90.75%
db_17847247775464589309.json[uncached] 15.4 ms 16.8 ms -8.08%
eucjp_1600564308684076393.json[uncached] 1,027.4 µs 959.3 µs +7.1%

@dyc3 dyc3 requested review from a team September 11, 2024 18:01
@dyc3 dyc3 merged commit 39a820e into main Sep 11, 2024
15 of 16 checks passed
@dyc3 dyc3 deleted the 09-10-fix_parser_html_correctly_lex_tag_names_and_attribute_names branch September 11, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L-HTML Language: HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants