fix(js_analyzer): don't flag duplicate hooks in describe.each for lint/suspicious/noDuplicateTestHooks #3806
+71
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/suspicious/noDuplicateTestHooks Since this rule didn't recognize describe.each has a different syntax from describe
github-actions
bot
added
A-Linter
vohoanglong0107
commented
Sep 6, 2024
Comment on lines
-315
to
-319
| 90 │ describe.each(["world"])("%s", () => { | ||
| > 91 │ beforeEach(() => {}); | ||
| │ ^^^^^^^^^^^^^^^^^^^^ | ||
| 92 │ beforeEach(() => {}); | ||
| 93 │ |
There was a problem hiding this comment.
This is undesirable behavior. We should only flag the second beforeEach hook
Comment on lines
+315
to
+319
| 76 │ describe.each(["hello"])("%s", () => { | ||
| 77 │ beforeEach(() => {}); | ||
| > 78 │ beforeEach(() => {}); | ||
| │ ^^^^^^^^^^^^^^^^^^^^ | ||
| 79 │ |
There was a problem hiding this comment.
This case was previously missed
CodSpeed Performance ReportMerging #3806 will not alter performanceComparing Summary
|
vohoanglong0107
changed the title
arendjr
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3291
Since noDuplicateTestHooks didn't know that
describe.eachhas a different syntax fromdescribeTest Plan
Added a new test for
describe.eachhook