ci: fix broken CLI binary copy step for NPM publish #3805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I've pinged the other maintainers about this so they can take a look before we release v1.9.0. |
|
Thanks, @dyc3! You won't be able to publish v1.9.0 successfully without a similar change to this one, so definitely worth addressing it prior to the release. 😅 Could I please also request that you guys publish another nightly after this merges? Unless v1.9.0 is expected to drop imminently, I'm currently blocked by the feature mentioned in biomejs/website#1058 not being available anywhere but in the (currently broken) nightly. |
I planned to release a nightly today or on Monday. |
Conaclos
approved these changes
Sep 6, 2024
|
Nightly published and working :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3804 - see that issue for discussion.
Test Plan
I'm not sure that it's possible to validate conclusively that this fixes #3804 without privileged access to the repository, as it's part of the NPM publish workflow.