Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(biome_parser): use enumflags2 for TokenFlag and remove bitflags #3802

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

Javimtib92
Copy link
Contributor

@Javimtib92 Javimtib92 commented Sep 5, 2024

Summary

Closes #3157

Adds enumflags2 to biome_parser TokenFlag and removes bitflags dependency from all Cargo.toml files where it is referenced.

Test Plan

I ran cargo t on the root and all tests passed. Current CI should pass

@github-actions github-actions bot added A-Linter Area: linter A-Parser Area: parser L-JavaScript Language: JavaScript and super languages labels Sep 5, 2024
Copy link
Contributor

@dyc3 dyc3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Great to be able to squeeze this in before v1.9.0

Copy link

codspeed-hq bot commented Sep 5, 2024

CodSpeed Performance Report

Merging #3802 will degrade performances by 7.04%

Comparing Javimtib92:refactor/remove-bitflags (1bdd8fe) with main (31d43b7)

Summary

❌ 1 regressions
✅ 106 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main Javimtib92:refactor/remove-bitflags Change
db_17847247775464589309.json[cached] 13 ms 14 ms -7.04%

@Javimtib92
Copy link
Contributor Author

Looks good! Great to be able to squeeze this in before v1.9.0

Great! Thanks for all the reviews 😊

@dyc3 dyc3 merged commit a3446a7 into biomejs:main Sep 6, 2024
13 of 14 checks passed
@Javimtib92 Javimtib92 deleted the refactor/remove-bitflags branch September 6, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter A-Parser Area: parser L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📎 Change bitflags for enumflags2
2 participants