Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(biome_js_parser/syntax): use enumflags2 for ModifierFlag #3796

Merged

Conversation

Javimtib92
Copy link
Contributor

Summary

Part of #3157

Adds enumflags2 to biome_js_parser ModifierFlag

Test Plan

I ran cargo t on the root and all tests passed. Current CI should pass

@github-actions github-actions bot added A-Parser Area: parser L-JavaScript Language: JavaScript and super languages labels Sep 5, 2024
Copy link

codspeed-hq bot commented Sep 5, 2024

CodSpeed Performance Report

Merging #3796 will improve performances by 6.03%

Comparing Javimtib92:refactor/js-parser-syntax-modifier-flag-enum (b17fa0a) with main (bcad101)

Summary

⚡ 1 improvements
✅ 106 untouched benchmarks

Benchmarks breakdown

Benchmark main Javimtib92:refactor/js-parser-syntax-modifier-flag-enum Change
db_17847247775464589309.json[uncached] 16.2 ms 15.3 ms +6.03%

@dyc3 dyc3 merged commit 3f1790e into biomejs:main Sep 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Parser Area: parser L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants