Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: v1.9.0 #3794

Merged
merged 58 commits into from
Sep 12, 2024
Merged

release: v1.9.0 #3794

merged 58 commits into from
Sep 12, 2024

Conversation

Conaclos
Copy link
Member

@Conaclos Conaclos commented Sep 5, 2024

Summary

  1. Add a changelog entry for every Pull Request that lacks one.
    You can filter merged PRs that don't update the changelog.
    Read our guidelines for editing the changelog.

  2. Based on the changelog, determine which version number to use.
    See our versioning guide for more details.

  3. Rename Unreleased to <version> (iso-date) in the changelog.

  4. Update version in Biome's package.json if applicable.

  5. Update to the same version in all crates if you publish crates. (Cargo.toml and crates/**/Cargo.toml)

  6. Linter rules have a version metadata directly defined in their implementation.
    This field is set to next for newly created rules.
    This field must be updated to the new version.

  7. Merge website PRs labeled "Merge on release".

  8. Update the website with the new version number:
    BIOME_VERSION=<version> just gen-web.
    This will also copy the configuration schema in the right place.

  9. Once the PR is merged, the CI will trigger the Release: * workflows. Once these workflows finish compiling the final artefact, they need to be approved manually.

@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project A-Linter Area: linter A-Parser Area: parser A-Tooling Area: internal tools L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis labels Sep 5, 2024
@Conaclos
Copy link
Member Author

Conaclos commented Sep 5, 2024

@togami2864 Which CSS rules do you think are ready to be promoted to the stable group?

Copy link
Contributor

github-actions bot commented Sep 5, 2024

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 48511 48511 0
Passed 47320 47320 0
Failed 1191 1191 0
Panics 0 0 0
Coverage 97.54% 97.54% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6569 6569 0
Passed 2202 2202 0
Failed 4367 4367 0
Panics 0 0 0
Coverage 33.52% 33.52% 0.00%

ts/babel

Test result main count This PR count Difference
Total 671 671 0
Passed 599 599 0
Failed 72 72 0
Panics 0 0 0
Coverage 89.27% 89.27% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18418 18418 0
Passed 14100 14100 0
Failed 4318 4318 0
Panics 0 0 0
Coverage 76.56% 76.56% 0.00%

Copy link

codspeed-hq bot commented Sep 5, 2024

CodSpeed Performance Report

Merging #3794 will degrade performances by 6.69%

Comparing release/1.9 (e09436f) with main (39a820e)

Summary

❌ 1 regressions
✅ 106 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main release/1.9 Change
react.production.min_3378072959512366797.js[cached] 1.9 ms 2 ms -6.69%

@arendjr
Copy link
Contributor

arendjr commented Sep 5, 2024

@Conaclos We should also not forget to merge website PRs labeled "Merge on release".

@Conaclos
Copy link
Member Author

Conaclos commented Sep 5, 2024

We should also not forget to merge website PRs labeled "Merge on release".

Thanks for the reminder! I added a bullet point.

@ematipico
Copy link
Member

A couple of other things for the website:

  • update the language support page with graphql
  • documentation for assists (or I can do it when I come back)
  • documentation for VSCode v3
  • document the guide to explain that with --verbose is now possible to see all fixed files

@togami2864
Copy link
Contributor

togami2864 commented Sep 5, 2024

@Conaclos
I think they would be good to be promoted

From stylelint-recommended

  • noDuplicateAtImportRules (suspicious)
  • noDuplicateFontNames (suspicious)
  • noDuplicateSelectorsKeyframeBlock (suspicious)
  • noEmptyBlock (suspicious)
  • noImportantInKeyframe (suspicious)
  • noInvalidDirectionInLinearGradient (correctness)
  • noInvalidPositionAtImportRule (correctness)
  • noIrregularWhitespace (suspicious) - looks like we have to promote both JS and CSS rules.
  • noShorthandPropertyOverrides (suspicious)
  • noUnknownFunction (correctness)
  • noUnknownMediaFeatureName (correctness)
  • noUnknownProperty (correctness)
  • noUnknownUnit (correctness)
  • noUnmatchableAnbSelector (correctness)
  • noInvalidGridAreas (correctness)
  • useGenericFontNames (a11y)

Other

  • noValueAtRule
stylelint biome note
no-duplicate-at-import-rules noDuplicateAtImportRules
font-family-no-duplicate-names noDuplicateFontNames
keyframe-block-no-duplicate-selectors noDuplicateSelectorsKeyframeBlock
block-no-empty noEmptyBlock
keyframe-declaration-no-important noImportantInKeyframe
function-linear-gradient-no-nonstandard-direction noInvalidDirectionInLinearGradient
no-invalid-position-at-import-rule noInvalidPositionAtImportRule
no-irregular-whitespace noIrregularWhitespace
declaration-block-no-shorthand-property-overrides noShorthandPropertyOverrides
function-no-unknown noUnknownFunction
media-feature-name-no-unknown noUnknownMediaFeatureName
property-no-unknown noUnknownProperty
unit-no-unknown noUnknownUnit
selector-anb-no-unmatchable noUnmatchableAnbSelector
named-grid-areas-no-invalid useConsistentGridAreas
font-family-no-missing-generic-family-keyword useGenericFontNames

@Conaclos
Copy link
Member Author

Conaclos commented Sep 5, 2024

@togami2864 Could you suggest a group for each one? (You can edit your comment).

EDIT: I started the assignment of groups.

@nhedger
Copy link
Member

nhedger commented Sep 5, 2024

A couple of other things for the website:

  • update the language support page with graphql
  • documentation for assists (or I can do it when I come back)
  • documentation for VSCode v3
  • document the guide to explain that with --verbose is now possible to see all fixed files

VS Code v3 might not be ready by release time. I need more time to squash bugs.

@Conaclos
Copy link
Member Author

Conaclos commented Sep 6, 2024

@togami2864
I chose a group for most of the rule.

If I am correct, useConsistentGridAreas is a correctness rule? However, its name sounds like a style rule. What do you think of renaming the rule to noInvalidGridAreas?

Also, I am thinking to accessibility for useGenericFontNames and correctness for all noUnknown* rules.

We will delay the promotion of noIrregularWhitespace to a next release because, both the JS and CSS rules have to be promoted.

@togami2864
Copy link
Contributor

togami2864 commented Sep 6, 2024

@Conaclos

If I am correct, useConsistentGridAreas is a correctness rule? However, its name sounds like a style rule. What do you think of renaming the rule to noInvalidGridAreas?

Totally agree 👍 I'll make a PR.

Also, I am thinking to accessibility for useGenericFontNames

This rule is originally from font-family-no-missing-generic-family-keyword in stylelint, I think it would be better to rename noMissingGenericFamilyKeyword and assign correctness group. wdyt 🤔

We will delay the promotion of noIrregularWhitespace to a next release because, both the JS and CSS rules have to be promoted.

👍


Besides that, I'll rename these rules to align with name conventions.

no_unknown_pseudo_class_selector => no_unknown_pseudo_class
no_unknown_selector_pseudo_element => no_unknown_pseudo_element

@Conaclos
Copy link
Member Author

Conaclos commented Sep 7, 2024

This rule is originally from font-family-no-missing-generic-family-keyword in stylelint, I think it would be better to rename noMissingGenericFamilyKeyword and assign correctness group. wdyt 🤔

Why should this be a correctness rule? This is not fundamentally wrong / an error of omitting a generic font family?
Regarding the name, I am not sure if it makes so much value of renaming it.

@togami2864
Copy link
Contributor

This is not fundamentally wrong / an error of omitting a generic font family?

That makes sense. Let's keep the rule name and assign it as accessibility.

CHANGELOG.md Outdated Show resolved Hide resolved
@Conaclos Conaclos force-pushed the release/1.9 branch 2 times, most recently from 2725f67 to 0a61431 Compare September 12, 2024 11:21
@Conaclos Conaclos force-pushed the release/1.9 branch 2 times, most recently from 4538c4e to e09436f Compare September 12, 2024 11:59
@github-actions github-actions bot added the A-LSP Area: language server protocol label Sep 12, 2024
@Conaclos Conaclos merged commit 894c3c5 into main Sep 12, 2024
14 of 15 checks passed
@Conaclos Conaclos deleted the release/1.9 branch September 12, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-CLI Area: CLI A-Diagnostic Area: diagnostocis A-Linter Area: linter A-LSP Area: language server protocol A-Parser Area: parser A-Project Area: project A-Tooling Area: internal tools L-CSS Language: CSS L-JavaScript Language: JavaScript and super languages L-JSON Language: JSON and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants