Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(biome_js_parser/syntax): use enumflags2 for TypeContext #3789

Merged

Conversation

Javimtib92
Copy link
Contributor

Summary

Part of #3157

Adds enumflags2 to biome_js_parser TypeContext.

⚠️ I realized that contains from enumflags2 is not const so this is forcing to remove const computation from some of the TypeContext methods. Please let me know If this is a problem, and if so, how to overcome this limitation.

Test Plan

I ran cargo t on the root and all tests passed. Current CI should pass

@github-actions github-actions bot added A-Parser Area: parser L-JavaScript Language: JavaScript and super languages labels Sep 4, 2024
Copy link

codspeed-hq bot commented Sep 5, 2024

CodSpeed Performance Report

Merging #3789 will not alter performance

Comparing Javimtib92:refactor/js-parser-syntax-type-context-enum (3f067b9) with main (e2171d3)

Summary

✅ 107 untouched benchmarks

@dyc3 dyc3 merged commit 8dcfff0 into biomejs:main Sep 5, 2024
13 checks passed
@Javimtib92 Javimtib92 deleted the refactor/js-parser-syntax-type-context-enum branch September 5, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Parser Area: parser L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants