-
-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(format/html): attribute formatting #3783
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyc3
force-pushed
the
09-04-feat_format_html_attribute_formatting
branch
from
September 4, 2024 17:26
6115cd3
to
e4d6be5
Compare
CodSpeed Performance ReportMerging #3783 will degrade performances by 8.2%Comparing Summary
Benchmarks breakdown
|
dyc3
force-pushed
the
09-04-feat_format_html_attribute_formatting
branch
from
September 6, 2024 10:20
e4d6be5
to
082126a
Compare
Parser conformance results onjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
dyc3
force-pushed
the
09-04-feat_format_html_attribute_formatting
branch
from
September 6, 2024 10:33
082126a
to
251d09e
Compare
dyc3
changed the title
feat(format/html): minimal attribute formatting
feat(format/html): attribute formatting
Sep 9, 2024
dyc3
force-pushed
the
09-04-feat_format_html_attribute_formatting
branch
2 times, most recently
from
September 10, 2024 09:59
f156dab
to
a64ff8e
Compare
github-actions
bot
removed
A-Project
Area: project
A-Tooling
Area: internal tools
labels
Sep 10, 2024
dyc3
force-pushed
the
09-04-feat_format_html_attribute_formatting
branch
from
September 10, 2024 13:33
a64ff8e
to
da90cc9
Compare
dyc3
force-pushed
the
09-04-feat_format_html_attribute_formatting
branch
from
September 10, 2024 14:02
da90cc9
to
a336f88
Compare
Conaclos
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to provide a good starting point for implementing attribute list formatting and to match prettier's behavior regarding html attributes and initializer clause quotes.
Prettier always uses double quotes for these, regardless of the actual quote style configuration (according to our playground).
Test Plan
Manually tested it using
quick_test
.Planning to bring in prettier's unit tests in another PR.