Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(format/html): add quick_test to formatter crate #3777

Merged

Conversation

dyc3
Copy link
Contributor

@dyc3 dyc3 commented Sep 4, 2024

Summary

This PR adds quick_test to biome_html_formatter. This is equivalent to the quick_tests in other formatter crates.

Test Plan

CI passes, and running the quick test works.

@github-actions github-actions bot added the A-Project Area: project label Sep 4, 2024
@dyc3 dyc3 changed the title feat(html/format): add quick_test to formatter crate feat(format/html): add quick_test to formatter crate Sep 4, 2024
@dyc3 dyc3 force-pushed the 09-03-feat_html_format_add_quick_test_to_formatter_crate branch from 2949e74 to daee85e Compare September 4, 2024 10:35
@dyc3 dyc3 force-pushed the 09-03-feat_html_format_add_quick_test_to_formatter_crate branch from daee85e to c3b6ef7 Compare September 4, 2024 10:42
Copy link

codspeed-hq bot commented Sep 4, 2024

CodSpeed Performance Report

Merging #3777 will improve performances by 19.09%

Comparing 09-03-feat_html_format_add_quick_test_to_formatter_crate (c3b6ef7) with main (3180697)

Summary

⚡ 1 improvements
✅ 106 untouched benchmarks

Benchmarks breakdown

Benchmark main 09-03-feat_html_format_add_quick_test_to_formatter_crate Change
big5-added_15586211152145260264.json[uncached] 649.3 µs 545.3 µs +19.09%

@dyc3 dyc3 marked this pull request as ready for review September 4, 2024 11:33
@dyc3 dyc3 requested a review from a team September 4, 2024 11:33
Copy link
Member

@chansuke chansuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dyc3 dyc3 merged commit 1ab9a92 into main Sep 4, 2024
15 checks passed
@dyc3 dyc3 deleted the 09-03-feat_html_format_add_quick_test_to_formatter_crate branch September 4, 2024 12:51
@dyc3 dyc3 added the L-HTML Language: HTML label Sep 5, 2024
@Conaclos Conaclos added the A-Changelog Area: changelog label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Project Area: project L-HTML Language: HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants