fix(parser/html): fix parsing html
keyword in doctype
#3776
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes incorrect lexing and parsing for HTML in the
doctype
directive node. It doesn't completely resolve everything parsing related todoctype
-- I've left that to a future PR because the context forquirk
,public_id
andsystem_id
is not really clear, even from looking at the HTML spec. But this should reasonably cover modern html documents.Test Plan
Updated the unit tests