Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(html): set up biome_html_formatter #3773

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Conversation

dyc3
Copy link
Contributor

@dyc3 dyc3 commented Sep 3, 2024

Summary

This PR aims to get all of the boilerplate stuff out of the way so that people can start working on implementing formatting logic for HTML.

This most of the code is codegened, but the other stuff is based heavily off of the js formatter.

Test Plan

It builds.

@github-actions github-actions bot added the A-Tooling Area: internal tools label Sep 3, 2024
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 48504 48504 0
Passed 47313 47313 0
Failed 1191 1191 0
Panics 0 0 0
Coverage 97.54% 97.54% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6568 6568 0
Passed 2201 2201 0
Failed 4367 4367 0
Panics 0 0 0
Coverage 33.51% 33.51% 0.00%

ts/babel

Test result main count This PR count Difference
Total 671 671 0
Passed 599 599 0
Failed 72 72 0
Panics 0 0 0
Coverage 89.27% 89.27% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18417 18417 0
Passed 14099 14099 0
Failed 4318 4318 0
Panics 0 0 0
Coverage 76.55% 76.55% 0.00%

@dyc3 dyc3 force-pushed the 09-03-feat_set_up_html_formatter branch from b081c23 to 6a8ddba Compare September 3, 2024 14:53
@dyc3 dyc3 force-pushed the 09-03-feat_set_up_html_formatter branch from 6a8ddba to 802fb7b Compare September 3, 2024 15:08
Copy link

codspeed-hq bot commented Sep 3, 2024

CodSpeed Performance Report

Merging #3773 will not alter performance

Comparing 09-03-feat_set_up_html_formatter (802fb7b) with main (73656ec)

Summary

✅ 99 untouched benchmarks

@dyc3 dyc3 marked this pull request as ready for review September 3, 2024 16:07
@dyc3 dyc3 requested a review from a team September 3, 2024 16:07
@dyc3 dyc3 merged commit 3180697 into main Sep 4, 2024
16 checks passed
@dyc3 dyc3 deleted the 09-03-feat_set_up_html_formatter branch September 4, 2024 10:09
@dyc3 dyc3 added the L-HTML Language: HTML label Sep 5, 2024
@Conaclos Conaclos added the A-Changelog Area: changelog label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Tooling Area: internal tools L-HTML Language: HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants