Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't panic in debug mode when encountring complex variable declaration #3769

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

Conaclos
Copy link
Member

@Conaclos Conaclos commented Sep 3, 2024

Summary

Fix #3740

@github-actions github-actions bot added A-Parser Area: parser L-JavaScript Language: JavaScript and super languages labels Sep 3, 2024
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 48504 48504 0
Passed 47313 47313 0
Failed 1191 1191 0
Panics 0 0 0
Coverage 97.54% 97.54% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6568 6568 0
Passed 2201 2201 0
Failed 4367 4367 0
Panics 0 0 0
Coverage 33.51% 33.51% 0.00%

ts/babel

Test result main count This PR count Difference
Total 671 671 0
Passed 599 599 0
Failed 72 72 0
Panics 0 0 0
Coverage 89.27% 89.27% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18417 18417 0
Passed 14099 14099 0
Failed 4318 4318 0
Panics 0 0 0
Coverage 76.55% 76.55% 0.00%

Copy link

codspeed-hq bot commented Sep 3, 2024

CodSpeed Performance Report

Merging #3769 will not alter performance

Comparing conaclos/remove-wrong-debug-assert (02a48f6) with main (49e2103)

Summary

✅ 99 untouched benchmarks

@Conaclos Conaclos merged commit 0b83351 into main Sep 3, 2024
16 checks passed
@Conaclos Conaclos deleted the conaclos/remove-wrong-debug-assert branch September 3, 2024 11:17
@Conaclos Conaclos added the A-Changelog Area: changelog label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Parser Area: parser L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 assertion failed: p.state().name_map.is_empty()
1 participant