Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useExhaustiveDependencies): make stableResult optional #3764

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

Conaclos
Copy link
Member

@Conaclos Conaclos commented Sep 2, 2024

Summary

Fix #3763

Test Plan

CI must pass.

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Sep 2, 2024
Copy link

codspeed-hq bot commented Sep 2, 2024

CodSpeed Performance Report

Merging #3764 will degrade performances by 6.57%

Comparing conaclos/fix-3763 (5ea1bb3) with main (7bcda36)

Summary

❌ 1 regressions
✅ 98 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main conaclos/fix-3763 Change
pure_9395922602181450299.css[cached] 3.9 ms 4.2 ms -6.57%

@Conaclos Conaclos merged commit 35e9e6d into main Sep 2, 2024
14 checks passed
@Conaclos Conaclos deleted the conaclos/fix-3763 branch September 2, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 json shcema for options of useExhaustiveDependencies incorrectly requires stableResult
1 participant