feat(search): add matches number to summary #3747
Merged
+32
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arendjr
reviewed
Sep 1, 2024
| @@ -27,6 +27,8 @@ pub(crate) enum FileStatus { | |||
| Unchanged, | |||
| /// While handling the file, something happened | |||
| Message(Message), | |||
| /// A match was found while searching a file | |||
| Search(Message), | |||
There was a problem hiding this comment.
Maybe Match or SearchResult is a better name? It doesn't seem to be used generically for messages from the search command.
There was a problem hiding this comment.
SearchResult sounds better, thank you 🙏
| @@ -691,6 +700,11 @@ fn handle_file(ctx: &TraversalOptions, path: &BiomePath) { | |||
| Ok(Ok(FileStatus::Unchanged)) => { | |||
| ctx.increment_unchanged(); | |||
| } | |||
| Ok(Ok(FileStatus::Search(msg))) => { | |||
| ctx.increment_changed(path); | |||
There was a problem hiding this comment.
What purpose is there for bumping changed? It feels semantically off, and I don't see why it's necessary...
There was a problem hiding this comment.
My bad, I meant to increment the unchanged files, aka when a match is found in a file it will still report that file as "searched"
BackupMiles
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to provide a summary of the search command, citing how many matches were found during the operation.
Test Plan
No tests have been provided.