Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: avoid UTF-8 validation of file extensions #3737

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

Conaclos
Copy link
Member

@Conaclos Conaclos commented Aug 28, 2024

Summary

Minor changes to avoid some UTF-8 validations when we retrieve the extension of a file path.

Test Plan

CI must pass.

@github-actions github-actions bot added A-CLI Area: CLI A-Core Area: core A-Project Area: project A-Linter Area: linter A-LSP Area: language server protocol L-JavaScript Language: JavaScript and super languages labels Aug 28, 2024
Copy link

codspeed-hq bot commented Aug 28, 2024

CodSpeed Performance Report

Merging #3737 will degrade performances by 7.66%

Comparing conaclos/minor-change (bf0551d) with main (42e45e6)

Summary

❌ 1 regressions
✅ 98 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main conaclos/minor-change Change
react.production.min_3378072959512366797.js[cached] 1.9 ms 2 ms -7.66%

@Conaclos Conaclos merged commit dc5c602 into main Aug 28, 2024
15 of 16 checks passed
@Conaclos Conaclos deleted the conaclos/minor-change branch August 28, 2024 19:28
@Conaclos Conaclos added the A-Changelog Area: changelog label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-CLI Area: CLI A-Core Area: core A-Linter Area: linter A-LSP Area: language server protocol A-Project Area: project L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants